You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/01 03:20:12 UTC

[GitHub] [shardingsphere] lhyundeadsoul opened a new pull request, #20702: Update sql-error-code.cn.md

lhyundeadsoul opened a new pull request, #20702:
URL: https://github.com/apache/shardingsphere/pull/20702

   Fixes https://github.com/apache/shardingsphere/pull/20677#discussion_r959520117
   
   Changes proposed in this pull request:
   -
   -
   -
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu closed pull request #20702: Update sql-error-code.cn.md

Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #20702: Update sql-error-code.cn.md
URL: https://github.com/apache/shardingsphere/pull/20702


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #20702: Update sql-error-code.cn.md

Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #20702:
URL: https://github.com/apache/shardingsphere/pull/20702#issuecomment-1234453713

   > > One exception should only have one vender code
   > 
   > Copy. So `org.apache.shardingsphere.sql.parser.exception.SQLParsingException` 's vendor code is always 11000.
   > 
   > Doc update: change | 42000 | 11000 | You have an error in your SQL syntax: `%s` | to | 42000 | 11000 | You have an error in your SQL syntax: `%s`, error message: `%s` |
   > 
   > Am I right?
   
   Unfortunately no, one exception only has one error message, please split different message into two exceptions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] lhyundeadsoul commented on pull request #20702: Update sql-error-code.cn.md

Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on PR #20702:
URL: https://github.com/apache/shardingsphere/pull/20702#issuecomment-1233800179

   > The document already existed in `11000`
   
   Yes, it already existed. But according to [this comment](https://github.com/apache/shardingsphere/pull/20677#discussion_r959520117) there is a new little clip `error message: %s` which contains the more detailed error message. 
   
   So, please let me know which one fits the code of conduct better.
   
   1. 
   | 42000 | 11000 | You have an error in your SQL syntax: \`%s\ |
   | 42000 | 11004 | You have an error in your SQL syntax: \`%s\`, error message: \`%s\` |
   
   2. 
   | 42000 | 11000 | You have an error in your SQL syntax: \`%s\ |
   | 42000 | 11000 | You have an error in your SQL syntax: \`%s\`, error message: \`%s\` |
   
   3.
   change 
   | 42000 | 11000 | You have an error in your SQL syntax: \`%s\ |
   to
   | 42000 | 11000 | You have an error in your SQL syntax: \`%s\`, error message: \`%s\` |
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] lhyundeadsoul commented on pull request #20702: Update sql-error-code.cn.md

Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on PR #20702:
URL: https://github.com/apache/shardingsphere/pull/20702#issuecomment-1234015831

   > One exception should only have one vender code
   Copy.
   So `org.apache.shardingsphere.sql.parser.exception.SQLParsingException` 's vendor code is always 11000.
   
   Doc update:
   change
   | 42000 | 11000 | You have an error in your SQL syntax: `%s\ |
   to
   | 42000 | 11000 | You have an error in your SQL syntax: `%s`, error message: `%s` |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #20702: Update sql-error-code.cn.md

Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #20702:
URL: https://github.com/apache/shardingsphere/pull/20702#issuecomment-1234417673

   > > One exception should only have one vender code
   > 
   > Copy. So `org.apache.shardingsphere.sql.parser.exception.SQLParsingException` 's vendor code is always 11000.
   > 
   > Doc update: change | 42000 | 11000 | You have an error in your SQL syntax: `%s` | to | 42000 | 11000 | You have an error in your SQL syntax: `%s`, error message: `%s` |
   > 
   > Am I right?
   
   Unfortunately no, one exception only has one error message, please split different message into two exceptions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #20702: Update sql-error-code.cn.md

Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #20702:
URL: https://github.com/apache/shardingsphere/pull/20702#issuecomment-1242893611

   If no update, I just close this issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #20702: Update sql-error-code.cn.md

Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #20702:
URL: https://github.com/apache/shardingsphere/pull/20702#issuecomment-1233960078

   One exception should only have one vender code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org