You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "aFlyBird0 (via GitHub)" <gi...@apache.org> on 2023/04/21 09:13:59 UTC
[GitHub] [incubator-devlake-website] aFlyBird0 opened a new pull request, #494: ci: check broken links during pr and main branch daily #491
aFlyBird0 opened a new pull request, #494:
URL: https://github.com/apache/incubator-devlake-website/pull/494
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [x] I have `npm run build` and `npm run serve` locally before submitting this PR
- [x] I have read through the [Contributing](https://devlake.apache.org/community/) Documentation
# Summary
check broken links during
* pr
* main branch daily. And submit an issue automatically if there are broken links
### Does this close any open issues?
Closes #491
### Screenshots
example action run: https://github.com/aFlyBird0/incubator-devlake-website/actions/runs/4763017396/jobs/8465932671
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] klesh commented on a diff in pull request #494: ci: check broken links during pr and main branch daily #491
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on code in PR #494:
URL: https://github.com/apache/incubator-devlake-website/pull/494#discussion_r1174500063
##########
.github/workflows/link-schedule.yaml:
##########
@@ -0,0 +1,48 @@
+name: Build workflow
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: "0 0 * * *"
+
+jobs:
+ build-and-check-links:
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@main
+
+ - name: Use Node.js 17.8.x
+ uses: actions/setup-node@main
+ with:
+ node-version: 17.8.x
+ - name: Build Docusaurus website
+ run: |
+ npm install
+ npm run build
+ - name: Link Checker
+ uses: lycheeverse/lychee-action@v1.5.0
Review Comment:
Oh, I don't think this would work...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] aFlyBird0 commented on pull request #494: ci: check broken links during pr and main branch daily #491
Posted by "aFlyBird0 (via GitHub)" <gi...@apache.org>.
aFlyBird0 commented on PR #494:
URL: https://github.com/apache/incubator-devlake-website/pull/494#issuecomment-1517546004
Hi Devlake Team 🙌, you could merge this pr first. Then I will try to fix all broken links in next pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] aFlyBird0 commented on pull request #494: ci: check broken links during pr #491
Posted by "aFlyBird0 (via GitHub)" <gi...@apache.org>.
aFlyBird0 commented on PR #494:
URL: https://github.com/apache/incubator-devlake-website/pull/494#issuecomment-1519063453
@klesh I have update the actions code and update the PR body. Please review it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] aFlyBird0 commented on pull request #494: ci: check broken links during pr #491
Posted by "aFlyBird0 (via GitHub)" <gi...@apache.org>.
aFlyBird0 commented on PR #494:
URL: https://github.com/apache/incubator-devlake-website/pull/494#issuecomment-1521198486
@klesh I have fixed almost all broken links: https://github.com/aFlyBird0/incubator-devlake-website/actions/runs/4794001248
except these two links:
The first link is a GitHub account that seems to have been deleted. I haven't found the current address for the second link yet.
<img width="1153" alt="image" src="https://user-images.githubusercontent.com/36830265/234187488-e3fb92c3-a556-467f-96a9-fe9c8965debb.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] klesh merged pull request #494: ci: check broken links during pr #491
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #494:
URL: https://github.com/apache/incubator-devlake-website/pull/494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] aFlyBird0 commented on a diff in pull request #494: ci: check broken links during pr and main branch daily #491
Posted by "aFlyBird0 (via GitHub)" <gi...@apache.org>.
aFlyBird0 commented on code in PR #494:
URL: https://github.com/apache/incubator-devlake-website/pull/494#discussion_r1174501037
##########
.github/workflows/link-schedule.yaml:
##########
@@ -0,0 +1,48 @@
+name: Build workflow
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: "0 0 * * *"
+
+jobs:
+ build-and-check-links:
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@main
+
+ - name: Use Node.js 17.8.x
+ uses: actions/setup-node@main
+ with:
+ node-version: 17.8.x
+ - name: Build Docusaurus website
+ run: |
+ npm install
+ npm run build
+ - name: Link Checker
+ uses: lycheeverse/lychee-action@v1.5.0
Review Comment:
Got it, thank you. I'll use cmd line to refactor it and send a new review request after finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] klesh commented on pull request #494: ci: check broken links during pr #491
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #494:
URL: https://github.com/apache/incubator-devlake-website/pull/494#issuecomment-1519254641
@aFlyBird0 Seems like some checks didn't pass, was it expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] aFlyBird0 commented on pull request #494: ci: check broken links during pr #491
Posted by "aFlyBird0 (via GitHub)" <gi...@apache.org>.
aFlyBird0 commented on PR #494:
URL: https://github.com/apache/incubator-devlake-website/pull/494#issuecomment-1519267852
> @aFlyBird0 Seems like some checks didn't pass, was it expected?
Yes, I'll fix broken links in next PR. This PR is only for actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org