You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "Pengzna (via GitHub)" <gi...@apache.org> on 2025/03/15 14:18:38 UTC
[PR] chore(backend): disable unnecssary backends [incubator-hugegraph]
Pengzna opened a new pull request, #2746:
URL: https://github.com/apache/incubator-hugegraph/pull/2746
as title.
sub task of https://github.com/apache/incubator-hugegraph/issues/2724
in 1.7.0, we tend to disable cassandra, mysql, postgresql, cockroachdb or palo as backend.
only hstore, rocksdb, hbase, memory are supported for backend.
if user want to use cassandra, mysql, postgresql, cockroachdb or palo as backend, please find a version before 1.7.0 of apache hugegraph for your application.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore(backend): disable unnecssary backends [incubator-hugegraph]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2746:
URL: https://github.com/apache/incubator-hugegraph/pull/2746#issuecomment-2726633452
## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2746?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
> Project coverage is 0.08%. Comparing base [(`a4cb44e`)](https://app.codecov.io/gh/apache/incubator-hugegraph/commit/a4cb44ea8fd0272179d1b441800f7a52c5713021?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`312fd7f`)](https://app.codecov.io/gh/apache/incubator-hugegraph/commit/312fd7fda3bdffff922b645913a754c68fa99c6b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2746?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ugegraph/backend/store/BackendProviderFactory.java](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2746?src=pr&el=tree&filepath=hugegraph-server%2Fhugegraph-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhugegraph%2Fbackend%2Fstore%2FBackendProviderFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVnZWdyYXBoLXNlcnZlci9odWdlZ3JhcGgtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvQmFja2VuZFByb3ZpZGVyRmFjdG9yeS5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (a4cb44e) and HEAD (312fd7f). Click for more details.
>
> <details><summary>HEAD has 6 uploads less than BASE</summary>
>
>| Flag | BASE (a4cb44e) | HEAD (312fd7f) |
>|------|------|------|
>||7|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2746 +/- ##
============================================
- Coverage 46.98% 0.08% -46.90%
+ Complexity 821 22 -799
============================================
Files 745 723 -22
Lines 60060 57537 -2523
Branches 7669 7222 -447
============================================
- Hits 28218 51 -28167
- Misses 29018 57484 +28466
+ Partials 2824 2 -2822
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2746?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>🚀 New features to boost your workflow: </summary>
- ❄ [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore(backend): disable unnecssary backends [incubator-hugegraph]
Posted by "zyxxoo (via GitHub)" <gi...@apache.org>.
zyxxoo commented on code in PR #2746:
URL: https://github.com/apache/incubator-hugegraph/pull/2746#discussion_r1998276201
##########
hugegraph-server/hugegraph-dist/src/assembly/travis/install-backend.sh:
##########
@@ -32,20 +32,20 @@ fi
case $BACKEND in
cassandra)
# TODO: replace it with docker
- "$TRAVIS_DIR"/install-cassandra.sh
+ echo "cassandra is not supported since 1.7.0"
;;
scylladb)
- "$TRAVIS_DIR"/install-scylladb.sh
+ echo "scylladb is not supported since 1.7.0"
Review Comment:
exit 1
##########
hugegraph-server/hugegraph-dist/src/assembly/travis/install-backend.sh:
##########
@@ -32,20 +32,20 @@ fi
case $BACKEND in
cassandra)
# TODO: replace it with docker
- "$TRAVIS_DIR"/install-cassandra.sh
+ echo "cassandra is not supported since 1.7.0"
;;
scylladb)
- "$TRAVIS_DIR"/install-scylladb.sh
+ echo "scylladb is not supported since 1.7.0"
;;
hbase)
# TODO: replace it with hbase2.3+ to avoid java8 env
"$TRAVIS_DIR"/install-hbase.sh
;;
mysql)
- "$TRAVIS_DIR"/install-mysql-via-docker.sh
+ echo "mysql is not supported since 1.7.0"
Review Comment:
exit 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore(backend): disable unnecssary backends [incubator-hugegraph]
Posted by "zyxxoo (via GitHub)" <gi...@apache.org>.
zyxxoo commented on code in PR #2746:
URL: https://github.com/apache/incubator-hugegraph/pull/2746#discussion_r1998275264
##########
hugegraph-server/hugegraph-dist/src/assembly/travis/install-backend.sh:
##########
@@ -32,20 +32,20 @@ fi
case $BACKEND in
cassandra)
# TODO: replace it with docker
- "$TRAVIS_DIR"/install-cassandra.sh
+ echo "cassandra is not supported since 1.7.0"
Review Comment:
exit 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore(backend): disable unnecssary backends [incubator-hugegraph]
Posted by "Pengzna (via GitHub)" <gi...@apache.org>.
Pengzna commented on code in PR #2746:
URL: https://github.com/apache/incubator-hugegraph/pull/2746#discussion_r2024566201
##########
hugegraph-server/hugegraph-dist/src/assembly/travis/install-backend.sh:
##########
@@ -32,20 +32,20 @@ fi
case $BACKEND in
cassandra)
# TODO: replace it with docker
- "$TRAVIS_DIR"/install-cassandra.sh
+ echo "cassandra is not supported since 1.7.0"
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] BREAKING CHANGE(server): disable legacy backends include `MySQL/PG/c*`(.etc) [incubator-hugegraph]
Posted by "JackyYangPassion (via GitHub)" <gi...@apache.org>.
JackyYangPassion merged PR #2746:
URL: https://github.com/apache/incubator-hugegraph/pull/2746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore(backend): disable unnecssary backends [incubator-hugegraph]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2746:
URL: https://github.com/apache/incubator-hugegraph/pull/2746#discussion_r2020115265
##########
hugegraph-server/README.md:
##########
@@ -8,4 +8,4 @@ HugeGraph Server consists of two layers of functionality: the graph engine layer
- Backend Interface: Implements the storage of graph data to the backend.
- Storage Layer:
- - Storage Backend: Supports multiple built-in storage backends (RocksDB/MySQL/HBase/...) and allows users to extend custom backends without modifying the existing source code.
+ - Storage Backend: Supports multiple built-in storage backends (RocksDB/Memory/Hstore/HBase/...) and allows users to extend custom backends without modifying the existing source code.
Review Comment:
[nitpick] Consider using a consistent case for 'Hstore' (e.g. 'HStore') to match naming conventions used elsewhere in the project.
```suggestion
- Storage Backend: Supports multiple built-in storage backends (RocksDB/Memory/HStore/HBase/...) and allows users to extend custom backends without modifying the existing source code.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore(backend): disable unnecssary backends [incubator-hugegraph]
Posted by "zyxxoo (via GitHub)" <gi...@apache.org>.
zyxxoo commented on code in PR #2746:
URL: https://github.com/apache/incubator-hugegraph/pull/2746#discussion_r1998275264
##########
hugegraph-server/hugegraph-dist/src/assembly/travis/install-backend.sh:
##########
@@ -32,20 +32,20 @@ fi
case $BACKEND in
cassandra)
# TODO: replace it with docker
- "$TRAVIS_DIR"/install-cassandra.sh
+ echo "cassandra is not supported since 1.7.0"
Review Comment:
echo 'xxxx'
exit 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore(backend): disable unnecssary backends [incubator-hugegraph]
Posted by "zyxxoo (via GitHub)" <gi...@apache.org>.
zyxxoo commented on code in PR #2746:
URL: https://github.com/apache/incubator-hugegraph/pull/2746#discussion_r1998276658
##########
hugegraph-server/hugegraph-dist/src/assembly/travis/install-backend.sh:
##########
@@ -32,20 +32,20 @@ fi
case $BACKEND in
cassandra)
# TODO: replace it with docker
- "$TRAVIS_DIR"/install-cassandra.sh
+ echo "cassandra is not supported since 1.7.0"
;;
scylladb)
- "$TRAVIS_DIR"/install-scylladb.sh
+ echo "scylladb is not supported since 1.7.0"
;;
hbase)
# TODO: replace it with hbase2.3+ to avoid java8 env
"$TRAVIS_DIR"/install-hbase.sh
;;
mysql)
- "$TRAVIS_DIR"/install-mysql-via-docker.sh
+ echo "mysql is not supported since 1.7.0"
;;
postgresql)
- "$TRAVIS_DIR"/install-postgresql-via-docker.sh
+ echo "postgresql is not supported since 1.7.0"
Review Comment:
exit 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org