You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2016/07/13 11:20:47 UTC

[GitHub] zeppelin pull request #1181: ZEPPELIN-1168 Add http header X-Requested-By in...

GitHub user r-kamath opened a pull request:

    https://github.com/apache/zeppelin/pull/1181

    ZEPPELIN-1168 Add http header X-Requested-By in post request to Livy for CSRF protection

    ### What is this PR for?
    Add http header X-Requested-By in post request to Livy for CSRF protection
    
    ### What type of PR is it?
    Improvement
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1168
    
    ### How should this be tested?
    enable csrf_protection on livy and check for "CSRF protection is enabled" message in the Livy logs. If this header is missing Livy server will send the following error message "Missing Required Header for CSRF protection."
    
    ### Questions:
    * Does the licenses files need update? n/a
    * Is there breaking changes for older versions? n/a
    * Does this needs documentation? n/a


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/r-kamath/zeppelin ZEPPELIN-1168

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1181
    
----
commit 3bae7a5e87fd614a1e90d0d5aa128a78c68342f0
Author: Renjith Kamath <re...@gmail.com>
Date:   2016-07-13T11:11:21Z

    ZEPPELIN-1168 Add http header X-Requested-By in post request to Livy Interpreter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1181: ZEPPELIN-1168 Add http header X-Requested-By in...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1181


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1181: ZEPPELIN-1168 Add http header X-Requested-By in post r...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1181
  
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1181: ZEPPELIN-1168 Add http header X-Requested-By in post r...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1181
  
    Merging this if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---