You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/09 10:12:49 UTC
[GitHub] cchung100m commented on a change in pull request #23730:
[SPARK-26822]Upgrade the deprecated module 'optparse'
cchung100m commented on a change in pull request #23730: [SPARK-26822]Upgrade the deprecated module 'optparse'
URL: https://github.com/apache/spark/pull/23730#discussion_r255294447
##########
File path: dev/run-tests.py
##########
@@ -636,6 +636,7 @@ def _test():
if failure_count:
sys.exit(-1)
+
Review comment:
Hi @HyukjinKwon
I add the new line to solve **PEP8: expected 2 blank lines after class or function definition, found 1**, do you suggest we ignore the PEP8 warning here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org