You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/27 19:21:44 UTC
[GitHub] [flink] viirya opened a new pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
viirya opened a new pull request #17582:
URL: https://github.com/apache/flink/pull/17582
## What is the purpose of the change
When creating Flink session cluster on K8S, Flink job manager won't create configmap for the Hadoop configuration stored in the Docker image.
Then when users submit Java application, the task manager Pods will not be abled to created, because it fails to mount the expected configmap of Hadoop configuration. This leads to a weird error and hard to understand for (new) Flink users.
This patch tries to fix this issue. So Flink users can include Hadoop classes and configuration in Docker image.
## Brief change log
- *Create resouces for task manager Pods*
## Verifying this change
This change can be verified as follows:
- *Manually verified the change by running a 6 node cluser with 1 JobManagers and 5 TaskManagers from a Docker image including Hadoop deps and configurations, a stateful streaming program, and verifying that TaskManage Pods can be created with Hadoop configmap.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gyfora commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-990913021
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
zentol edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-993328632
What makes you think that it is stuck?
The latest commit is 0d7fc49 , which is also reported as such in the [CI comment](https://github.com/apache/flink/pull/17582#issuecomment-953241058).
CI is failing because of formatting issues, so run `mvn spotless:apply` and commit the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d7fc494935f912b062887f75ce724a880b92076 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802)
* 58d6f6002e03bf6e6397ad343868fe311d4ac516 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3eb296e77182671d24dab3c29b9d874860165725 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
mbalassi commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-996539707
Thanks, @viirya. Interestingly these 2 issues seem to persist across at least 5 runs that I have seen on this PR. It feels completely unrelated to your change, but I will look into it a bit just to be on the safe side. I aim to merge the PR latest next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
mbalassi commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-993887799
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gyfora commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-964087450
Thank you @viirya , the change looks good from a high level but I haven't tested it myself yet.
Do you think it would make sense to include a test for the TM hadoop config similar to the ones in `KubernetesJobManagerFactoryTest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-966070024
Thanks for reviewing, @gyfora.
This issue happens when we put the Hadoop configuration in the docker image. In the case, Flink job manager won't create the configmap for task manager Pods. But when task manager Pods are going to be created, it expects there is a configmap of Hadoop configuration but there isn't. So the pods cannot be created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-966070024
Thanks for reviewing, @gyfora.
This issue happens when we put the Hadoop configuration in the docker image. In the case, Flink job manager won't create configmap for the Hadoop configuration. But when task manager Pods are going to be created, it expects there is a configmap of Hadoop configuration but there isn't. So the pods cannot be created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-989105805
The bot is slow ;)
@zentol knows how to debug it ;) Can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993887799",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 58d6f6002e03bf6e6397ad343868fe311d4ac516 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993887799",
"triggerType" : "MANUAL"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 58d6f6002e03bf6e6397ad343868fe311d4ac516 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094)
* ed1e59cced3590c5cbb27e0214b3746d148c8aa2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99fa2e362ef929e2549e5aa76ef2c11b7b39891d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d7fc494935f912b062887f75ce724a880b92076 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802)
* 58d6f6002e03bf6e6397ad343868fe311d4ac516 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
mbalassi commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-995521569
I see, @viirya. Sent you an email to address this separately from the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 58d6f6002e03bf6e6397ad343868fe311d4ac516 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993887799",
"triggerType" : "MANUAL"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"triggerType" : "PUSH"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "996443534",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* ed1e59cced3590c5cbb27e0214b3746d148c8aa2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-996521399
This time `testStopSavepointWithBoundedInput` was passed. But there is a python failure: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=28292&view=logs&j=dd7e7115-b4b1-5414-20ec-97b9411e0cfc&t=c759a57f-2774-59e9-f882-8e4d5d3fbb9f&l=21488. Looks like it failed at doc generation.
Another one is a failure during preparing e2e run: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=28292&view=logs&j=e428c73e-5bb8-51ab-b1f4-da736192251d&t=cd76fb27-06f2-5ebf-f6c8-46e811bf7787&l=1560. Seems it failed to get some ubuntu deb package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gyfora commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-989057821
@rmetzger any idea why the bot is nut triggered when I try to run commands?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-989027645
Seems CI isn't triggered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya commented on a change in pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #17582:
URL: https://github.com/apache/flink/pull/17582#discussion_r752848360
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java
##########
@@ -171,23 +181,25 @@ public void deregisterApplication(
parameters.getTaskManagerCPU());
final CompletableFuture<Void> createPodFuture =
- flinkKubeClient.createTaskManagerPod(taskManagerPod);
+ flinkKubeClient.createTaskManagerPod(taskManagerSpec);
+ final KubernetesPod finalTaskManagerPod = taskManagerPod;
+ final String finalPodName = podName;
Review comment:
Just tried it. Because we can only get `taskManagerPod`, `podName` in the try-catch block. If we put only `buildTaskManagerKubernetesPod` in there, we need to move `taskManagerSpec`, `podName`, `taskManagerPod` out of the block, i.e.,
```java
KubernetesTaskManagerSpecification taskManagerSpec = null;
KubernetesPod taskManagerPod = null;
String podName = null;
try {
taskManagerSpec = ...
...
} catch (Exception e) {
requestResourceFuture.completeExceptionally(e);
}
```
Due to "Variable used in lambda expression should be final or effectively final", I need to have copies of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
mbalassi commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-995062008
It problem is funny, when we add the `KerberosMountDecorator` it instantiates a `SecurityConfiguration`, which in its [validate](https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityConfiguration.java#L140-L162) method checks that the keytab location exists and is readable. The tests runs successfully if I disable the validation.
The reason while the validation fails is that the configuration is already updated to the keytab location that will be valid in the taskmanager pod, but we perform the validation on the local machine running the test. A naive approach to solving this would be modify the implementation of the `KerberosMountDecorator` to instead of using the `SecurityConfiguration` simply get the [kerberos configs](https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/KerberosMountDecorator.java#L67-L68) directly from the underlying (general flink) `Configuration` object, thus effectively circumventing the security configuration validation. I dislike this approach, we should rather coordinate the validation and the property setting just noting it to illustrate my point. 😊
@viirya could you please confirm whether this test runs in your environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
mbalassi commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-995155409
Hi @viirya,
Fair point. The jobmanager testcase runs fine, so investigating the gap can be a useful path to resolving this. The following works for me to reproduce:
```
cd flink-kubernetes
mvn test -Dtest=KubernetesTaskManagerFactoryTest
```
It might make sense to first run a `mvn clean install -DskipTests -Dfast` on the whole `flink` project, so you have all artifacts locally and then run the above to reproduce the test failure (even with these params building the project takes a while).
I also have the project imported into an IDE (IntelliJ in my case) and often run the tests there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-995275934
I got the following compilation error when running `mvn clean install -DskipTests -Dfast`:
```
[ERROR] /Users/viirya/repos/flink/flink-end-to-end-tests/flink-datastream-allround-test/target/generated-sources/org/apache/flink/streaming/tests/avro/ComplexPayloadAvro.java:[16,8] duplicate class: org.apache.flink.streaming.tests.avro.ComplexPayloadAvro
[ERROR] /Users/viirya/repos/flink/flink-end-to-end-tests/flink-datastream-allround-test/target/generated-sources/org/apache/flink/streaming/tests/avro/InnerPayLoadAvro.java:[16,8] duplicate class: org.apache.flink.streaming.tests.avro.InnerPayLoadAvro
```
Actually I encountered a few weird issues when building/compiling Flink project during the development like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993887799",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 58d6f6002e03bf6e6397ad343868fe311d4ac516 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
mbalassi commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-994704581
Hi @viirya,
The CI run has uncovered a test failure:
```
org.apache.flink.configuration.IllegalConfigurationException: Kerberos login configuration is invalid: keytab [/opt/kerberos/kerberos-keytab/keytab] doesn't exist!
at org.apache.flink.runtime.security.SecurityConfiguration.validate(SecurityConfiguration.java:151)
at org.apache.flink.runtime.security.SecurityConfiguration.<init>(SecurityConfiguration.java:97)
at org.apache.flink.runtime.security.SecurityConfiguration.<init>(SecurityConfiguration.java:69)
at org.apache.flink.kubernetes.kubeclient.decorators.KerberosMountDecorator.<init>(KerberosMountDecorator.java:58)
at org.apache.flink.kubernetes.kubeclient.factory.KubernetesTaskManagerFactory.buildKubernetesTaskManagerSpecification(KubernetesTaskManagerFactory.java:53)
at org.apache.flink.kubernetes.kubeclient.factory.KubernetesTaskManagerFactoryTest.testHadoopConfConfigMap(KubernetesTaskManagerFactoryTest.java:115)
```
I could successfully reproduce this locally on my machine after checking out the branch. Let me know if you have the time to fix this issue, I might take a look myself later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3eb296e77182671d24dab3c29b9d874860165725 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737)
* 0d7fc494935f912b062887f75ce724a880b92076 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d7fc494935f912b062887f75ce724a880b92076 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993887799",
"triggerType" : "MANUAL"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"triggerType" : "PUSH"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "996443534",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* ed1e59cced3590c5cbb27e0214b3746d148c8aa2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
mbalassi commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-996168516
Hey @viirya,
The update to the keytab location from the local environment running the test to the taskmanager pod happens [here](https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/KerberosMountDecorator.java#L160-L166), and we run into this because the `testHadoopConfConfigMap()` test you introduce in this PR ultimately calls the [`buildKubernetesTaskManagerSpecification`](https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/factory/KubernetesTaskManagerFactory.java#L41) twice. Once in the `onSetup` call and in the test function body itself, both calls are introduced in this PR.
The equivalent taskmanager test only makes this call once, it seems straight-forward from here to refactor your change to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-973717126
@gyfora I addressed your two previous comments. Thanks. I'll see if I can add a test for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gyfora edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
gyfora edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-989057821
@rmetzger any idea why the bot is not triggered when I try to run commands?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d7fc494935f912b062887f75ce724a880b92076 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 58d6f6002e03bf6e6397ad343868fe311d4ac516 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya closed pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #17582:
URL: https://github.com/apache/flink/pull/17582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya commented on a change in pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #17582:
URL: https://github.com/apache/flink/pull/17582#discussion_r747955432
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/factory/KubernetesTaskManagerFactory.java
##########
@@ -54,6 +63,7 @@ public static KubernetesPod buildTaskManagerKubernetesPod(
for (KubernetesStepDecorator stepDecorator : stepDecorators) {
flinkPod = stepDecorator.decorateFlinkPod(flinkPod);
+ accompanyingResources.addAll(stepDecorator.buildAccompanyingKubernetesResources());
Review comment:
@gyfora You can see that we didn't build accompanying resources previously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993887799",
"triggerType" : "MANUAL"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"triggerType" : "PUSH"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "996443534",
"triggerType" : "MANUAL"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "996851582",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* ed1e59cced3590c5cbb27e0214b3746d148c8aa2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993887799",
"triggerType" : "MANUAL"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"triggerType" : "PUSH"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "996443534",
"triggerType" : "MANUAL"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "996851582",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* ed1e59cced3590c5cbb27e0214b3746d148c8aa2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
mbalassi commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-996851582
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-995089485
@mbalassi Thanks for looking at this. I copied a similar from JobManager test case. So I expect it should run the same like the existing test...
I'm not able to run a single test in Flink. I'd like to know how to do it actually. `mvn -D<test> test` doesn't work at all...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d7fc494935f912b062887f75ce724a880b92076 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
mbalassi commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-996443534
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-996556367
Thank you @mbalassi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993887799",
"triggerType" : "MANUAL"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"triggerType" : "PUSH"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "996443534",
"triggerType" : "MANUAL"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "996851582",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* ed1e59cced3590c5cbb27e0214b3746d148c8aa2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gyfora commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-992255063
@rmetzger @zentol the CI/flinkbot seems to be stuck somehow, we would really appreciate some help :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gyfora commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-988696319
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d7fc494935f912b062887f75ce724a880b92076 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
mbalassi commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-993334213
Good catch @zentol, mea culpa.
@viirya could you please `mvn spotless:apply` and update your change? If the CI passes @gyfora or I will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-995164497
@mbalassi Thanks. Let me try it locally and debug the difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993887799",
"triggerType" : "MANUAL"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 58d6f6002e03bf6e6397ad343868fe311d4ac516 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094)
* ed1e59cced3590c5cbb27e0214b3746d148c8aa2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99fa2e362ef929e2549e5aa76ef2c11b7b39891d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540)
* 3eb296e77182671d24dab3c29b9d874860165725 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-995275934
I got the following compilation error when running `mvn clean install -DskipTests -Dfast`:
```
[ERROR] /Users/viirya/repos/flink/flink-end-to-end-tests/flink-datastream-allround-test/target/generated-sources/org/apache/flink/streaming/tests/avro/ComplexPayloadAvro.java:[16,8] duplicate class: org.apache.flink.streaming.tests.avro.ComplexPayloadAvro
[ERROR] /Users/viirya/repos/flink/flink-end-to-end-tests/flink-datastream-allround-test/target/generated-sources/org/apache/flink/streaming/tests/avro/InnerPayLoadAvro.java:[16,8] duplicate class: org.apache.flink.streaming.tests.avro.InnerPayLoadAvro
```
Actually I encountered a few weird issues like this when building/compiling Flink project during the development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993887799",
"triggerType" : "MANUAL"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"triggerType" : "PUSH"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "996443534",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* ed1e59cced3590c5cbb27e0214b3746d148c8aa2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 3eb296e77182671d24dab3c29b9d874860165725 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737)
* 0d7fc494935f912b062887f75ce724a880b92076 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3eb296e77182671d24dab3c29b9d874860165725 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737)
* 0d7fc494935f912b062887f75ce724a880b92076 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gyfora commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-964865674
Just one question so I understand the exact problem @viirya :
Does this issue only happen if you are using a custom taskmanager pod template in which you define the hadoop conf?
Because I see that we already create the config resources when the jobmanager is created here: https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java#L124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gyfora commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-993333826
@viirya could you please format the code with spotless and run the build locally to test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gyfora commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-966917424
Thank you for the clarification! Please address my initial comments and add a test case for this if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
mbalassi commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-991971232
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d7fc494935f912b062887f75ce724a880b92076 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
mbalassi commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-993668258
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-996268580
After update, the newly added test seems passed? I saw one test failure in CI report now https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=28292&view=logs&j=a57e0635-3fad-5b08-57c7-a4142d7d6fa9&t=2ef0effc-1da1-50e5-c2bd-aab434b1c5b7&l=10892.
`testStopSavepointWithBoundedInput` which looks not related to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993887799",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 58d6f6002e03bf6e6397ad343868fe311d4ac516 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gyfora commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-993333060
That’s true @zentol , I did not notice that as there were absolutely no feedback from the bot after I tried to trigger it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gyfora commented on a change in pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
gyfora commented on a change in pull request #17582:
URL: https://github.com/apache/flink/pull/17582#discussion_r745441165
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/factory/KubernetesTaskManagerFactory.java
##########
@@ -31,16 +32,24 @@
import org.apache.flink.kubernetes.kubeclient.resources.KubernetesPod;
import org.apache.flink.util.Preconditions;
+import io.fabric8.kubernetes.api.model.HasMetadata;
import io.fabric8.kubernetes.api.model.Pod;
import io.fabric8.kubernetes.api.model.PodBuilder;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
/** Utility class for constructing the TaskManager Pod on the JobManager. */
public class KubernetesTaskManagerFactory {
- public static KubernetesPod buildTaskManagerKubernetesPod(
- FlinkPod podTemplate, KubernetesTaskManagerParameters kubernetesTaskManagerParameters) {
+ public static KubernetesTaskManagerSpecification buildTaskManagerKubernetesPod(
Review comment:
This method should now be renamed to `buildKubernetesTaskManagerSpecification`
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java
##########
@@ -155,43 +156,49 @@ public void deregisterApplication(
TaskExecutorProcessSpec taskExecutorProcessSpec) {
final KubernetesTaskManagerParameters parameters =
createKubernetesTaskManagerParameters(taskExecutorProcessSpec);
- final KubernetesPod taskManagerPod =
- KubernetesTaskManagerFactory.buildTaskManagerKubernetesPod(
- taskManagerPodTemplate, parameters);
- final String podName = taskManagerPod.getName();
final CompletableFuture<KubernetesWorkerNode> requestResourceFuture =
new CompletableFuture<>();
- requestResourceFutures.put(podName, requestResourceFuture);
-
- log.info(
- "Creating new TaskManager pod with name {} and resource <{},{}>.",
- podName,
- parameters.getTaskManagerMemoryMB(),
- parameters.getTaskManagerCPU());
-
- final CompletableFuture<Void> createPodFuture =
- flinkKubeClient.createTaskManagerPod(taskManagerPod);
-
- FutureUtils.assertNoException(
- createPodFuture.handleAsync(
- (ignore, exception) -> {
- if (exception != null) {
- log.warn(
- "Could not create pod {}, exception: {}",
- podName,
- exception);
- CompletableFuture<KubernetesWorkerNode> future =
- requestResourceFutures.remove(taskManagerPod.getName());
- if (future != null) {
- future.completeExceptionally(exception);
+ try {
+ final KubernetesTaskManagerSpecification taskManagerSpec =
+ KubernetesTaskManagerFactory.buildTaskManagerKubernetesPod(
Review comment:
Why are we now wrapping everything in the try-catch block instead of only the `buildTaskManagerKubernetesPod` part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-966790147
Ah, this was done many months ago actually, though it is just submitted recently. So I may miss some details now.
The issue should be happened like:
Job manager will detect local hadoop configuration and create configmap mounted as volume in job Manager pod, that's no problem. For task manager, `HadoopConfMountDecorator` creates volume and tries to mount it. But the accompanying configmap for task manager is not created actually. So the task manager pods fail to mount it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99fa2e362ef929e2549e5aa76ef2c11b7b39891d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540)
* 3eb296e77182671d24dab3c29b9d874860165725 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99fa2e362ef929e2549e5aa76ef2c11b7b39891d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0d7fc494935f912b062887f75ce724a880b92076 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gyfora commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-990913483
@zentol seems like I cannot trigger the flinkbot with my user, do you have any idea why this might happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-993328632
What makes you think that it is stuck?
The latest commit is 0d7fc49 , which is also reported as such in the [CI comment](https://github.com/apache/flink/pull/17582#issuecomment-953241058).
CI is failing because of formatting issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 58d6f6002e03bf6e6397ad343868fe311d4ac516 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 58d6f6002e03bf6e6397ad343868fe311d4ac516 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-996173152
@mbalassi Thanks. I can reproduce the test failure locally after removing the files according to your email. I'm occupied by a relatively urgent work in Spark side in recent days. I will try to get some time update the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-953241058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25540",
"triggerID" : "99fa2e362ef929e2549e5aa76ef2c11b7b39891d",
"triggerType" : "PUSH"
}, {
"hash" : "3eb296e77182671d24dab3c29b9d874860165725",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26737",
"triggerID" : "3eb296e77182671d24dab3c29b9d874860165725",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "0d7fc494935f912b062887f75ce724a880b92076",
"triggerType" : "PUSH"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "988696319",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "990913021",
"triggerType" : "MANUAL"
}, {
"hash" : "0d7fc494935f912b062887f75ce724a880b92076",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27802",
"triggerID" : "991971232",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"triggerType" : "PUSH"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993668258",
"triggerType" : "MANUAL"
}, {
"hash" : "58d6f6002e03bf6e6397ad343868fe311d4ac516",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28094",
"triggerID" : "993887799",
"triggerType" : "MANUAL"
}, {
"hash" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292",
"triggerID" : "ed1e59cced3590c5cbb27e0214b3746d148c8aa2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed1e59cced3590c5cbb27e0214b3746d148c8aa2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28292)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] viirya commented on a change in pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #17582:
URL: https://github.com/apache/flink/pull/17582#discussion_r747956583
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java
##########
@@ -155,43 +156,49 @@ public void deregisterApplication(
TaskExecutorProcessSpec taskExecutorProcessSpec) {
final KubernetesTaskManagerParameters parameters =
createKubernetesTaskManagerParameters(taskExecutorProcessSpec);
- final KubernetesPod taskManagerPod =
- KubernetesTaskManagerFactory.buildTaskManagerKubernetesPod(
- taskManagerPodTemplate, parameters);
- final String podName = taskManagerPod.getName();
final CompletableFuture<KubernetesWorkerNode> requestResourceFuture =
new CompletableFuture<>();
- requestResourceFutures.put(podName, requestResourceFuture);
-
- log.info(
- "Creating new TaskManager pod with name {} and resource <{},{}>.",
- podName,
- parameters.getTaskManagerMemoryMB(),
- parameters.getTaskManagerCPU());
-
- final CompletableFuture<Void> createPodFuture =
- flinkKubeClient.createTaskManagerPod(taskManagerPod);
-
- FutureUtils.assertNoException(
- createPodFuture.handleAsync(
- (ignore, exception) -> {
- if (exception != null) {
- log.warn(
- "Could not create pod {}, exception: {}",
- podName,
- exception);
- CompletableFuture<KubernetesWorkerNode> future =
- requestResourceFutures.remove(taskManagerPod.getName());
- if (future != null) {
- future.completeExceptionally(exception);
+ try {
+ final KubernetesTaskManagerSpecification taskManagerSpec =
+ KubernetesTaskManagerFactory.buildTaskManagerKubernetesPod(
Review comment:
Not quite remember the reason. Let me see if I can only put `buildTaskManagerKubernetesPod` into the try-catch block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gyfora commented on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-966074245
> Thanks for reviewing, @gyfora.
>
> This issue happens when we put the Hadoop configuration in the docker image. In the case, Flink job manager won't create the configmap for task manager Pods. But when task manager Pods are going to be created, it expects there is a configmap of Hadoop configuration but there isn't. So the pods cannot be created.
I am just trying to understand why https://github.com/apache/flink/blob/99fa2e362ef929e2549e5aa76ef2c11b7b39891d/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java#L116 does not create it already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gyfora edited a comment on pull request #17582: [FLINK-24674][kubernetes] Create corresponding resouces for task manager Pods
Posted by GitBox <gi...@apache.org>.
gyfora edited a comment on pull request #17582:
URL: https://github.com/apache/flink/pull/17582#issuecomment-964087450
Thank you @viirya , the change looks good from a high level but I haven't tested it myself yet.
Do you think it would make sense to include a test for this in `Fabric8FlinkKubeClientTest` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org