You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/22 08:35:07 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #30788: [SPARK-33726][SQL] Fix for Duplicate field names during Aggregation

cloud-fan commented on a change in pull request #30788:
URL: https://github.com/apache/spark/pull/30788#discussion_r562467173



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -1079,6 +1079,16 @@ class DataFrameAggregateSuite extends QueryTest
     assert(aggs.head.output.map(_.dataType.simpleString).head ===
       aggs.last.output.map(_.dataType.simpleString).head)
   }
+
+  test("SPARK-33726: Aggregation on a table where a column name is reused") {
+    val query =
+      """|with T as (select id as a, -id as x from range(3)), U as (select id as b,

Review comment:
       let's properly format the SQL
   ```
   with t(
     ...)
   SELECT ...
   FROM ... JOIN ...
   GROUP BY ...
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org