You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/16 09:02:20 UTC
[jira] [Commented] (FLINK-4590) Some Table API tests are failing
when debug lvl is set to DEBUG
[ https://issues.apache.org/jira/browse/FLINK-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495808#comment-15495808 ]
ASF GitHub Bot commented on FLINK-4590:
---------------------------------------
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2504
[FLINK-4590] [table] Some Table API tests are failing when debug lvl is set to DEBUG
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
This PR fixes the estimated costs for minus and union DataSet RelNodes. I went through all RelNodes and also fixed multiple potential null pointers, bugs, and warnings.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-4590
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2504.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2504
----
commit a13e30799cb4a5d59de813b96d3519a337461aa6
Author: twalthr <tw...@apache.org>
Date: 2016-09-16T08:52:28Z
[FLINK-4590] [table] Some Table API tests are failing when debug lvl is set to DEBUG
----
> Some Table API tests are failing when debug lvl is set to DEBUG
> ---------------------------------------------------------------
>
> Key: FLINK-4590
> URL: https://issues.apache.org/jira/browse/FLINK-4590
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Robert Metzger
> Assignee: Timo Walther
>
> For debugging another issue, I've set the log level on travis to DEBUG.
> After that, the Table API tests started failing
> {code}
> Failed tests:
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while applying rule DataSetScanRule
> {code}
> Probably Calcite is executing additional assertions depending on the debug level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)