You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "mprins (via GitHub)" <gi...@apache.org> on 2026/01/02 10:17:28 UTC
[PR] SOLR-18003: The POM for org.apache.solr:solr-solrj:jar:11.0.0-SNAPSHOT is invalid [solr]
mprins opened a new pull request, #3998:
URL: https://github.com/apache/solr/pull/3998
This will make sure a valid Jackson version is available in the generated pom file
https://issues.apache.org/jira/browse/SOLR-18003
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Add `api platform(libs.fasterxml.jackson.bom)` to the solrj dependencies
# Solution
Import jackson-bom artifact to provide version information for the Jackson dependencies of solrj
# Tests
Checked that the jackson-bom artifact is in fact imported in the solrj pom file
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
- [x] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18003: The POM for org.apache.solr:solr-solrj:jar:11.0.0-SNAPSHOT is invalid [solr]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3998:
URL: https://github.com/apache/solr/pull/3998#discussion_r2657550340
##########
changelog/unreleased/SOLR-18003_jackson-bom_import.yml:
##########
@@ -0,0 +1,10 @@
+# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc
+title: Add the Jackson BOM import to solrj
+type: other # added, changed, fixed, deprecated, removed, dependency_update, security, other
Review Comment:
The type should be "fixed" instead of "other" since this change fixes an invalid POM issue. The "fixed" type is more appropriate for bug fixes and corrections.
```suggestion
type: fixed # added, changed, fixed, deprecated, removed, dependency_update, security, other
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18003: The POM for org.apache.solr:solr-solrj:jar:11.0.0-SNAPSHOT is invalid [solr]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3998:
URL: https://github.com/apache/solr/pull/3998#discussion_r2657457570
##########
solr/solrj/build.gradle:
##########
@@ -31,6 +31,7 @@ dependencies {
implementation libs.fasterxml.jackson.core.annotations
implementation libs.fasterxml.jackson.core.core
api project(":solr:api")
+ api platform(libs.fasterxml.jackson.bom)
Review Comment:
The Jackson BOM platform dependency should be declared before the Jackson implementation dependencies (lines 30-32) to properly control their versions. In Gradle, platform/BOM dependencies need to be declared before the actual library dependencies they manage to be effective.
This pattern is consistently followed in other modules in the codebase - for example, in solr/api/build.gradle, the BOM is declared at line 65 before any Jackson library dependencies at line 70. Similarly, in modules like gcs-repository, opentelemetry, and s3-repository, platform dependencies are declared at the beginning of the dependencies block.
Consider moving this line to appear before line 30, or at least before the Jackson library dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18003: The POM for org.apache.solr:solr-solrj:jar:11.0.0-SNAPSHOT is invalid [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #3998:
URL: https://github.com/apache/solr/pull/3998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org