You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Greg Miller (Jira)" <ji...@apache.org> on 2021/06/04 22:56:00 UTC
[jira] [Updated] (LUCENE-9991) Fix TestStringValueFacetCounts
[ https://issues.apache.org/jira/browse/LUCENE-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Miller updated LUCENE-9991:
--------------------------------
Description:
As reported by [~julietibs] in LUCENE-9950, there's a randomized test failure in {{TestStringValueFacetCounts}}. It's actually an issue with the test itself.
Since count ties are broken in {{StringValueFacetCounts}} by ordinal, but the test doesn't know anything about the ordinals, the test breaks ties by the value itself before comparing results. The edge-case is if we only request a topN of 1, but the top result ties in count with other results. In this scenario, the result returned by the {{Facets}} might be one that sorts higher than another when secondarily sorted by value, but the test can't solve for this since it only sees the one result. Should be a fairly simple fix in the test case itself. Will do so shortly.
was:
As [reported|https://issues.apache.org/jira/browse/LUCENE-9950?focusedCommentId=17357589&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17357589] by [~julietibs] in LUCNEE-9950, there's a randomized test failure in {{TestStringValueFacetCounts}}. It's actually an issue with the test itself.
Since count ties are broken in {{StringValueFacetCounts}} by ordinal, but the test doesn't know anything about the ordinals, the test breaks ties by the value itself before comparing results. The edge-case is if we only request a topN of 1, but the top result ties in count with other results. In this scenario, the result returned by the {{Facets}} might be one that sorts higher than another when secondarily sorted by value, but the test can't solve for this since it only sees the one result. Should be a fairly simple fix in the test case itself. Will do so shortly.
> Fix TestStringValueFacetCounts
> ------------------------------
>
> Key: LUCENE-9991
> URL: https://issues.apache.org/jira/browse/LUCENE-9991
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Affects Versions: main (9.0)
> Reporter: Greg Miller
> Priority: Minor
> Fix For: main (9.0)
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As reported by [~julietibs] in LUCENE-9950, there's a randomized test failure in {{TestStringValueFacetCounts}}. It's actually an issue with the test itself.
> Since count ties are broken in {{StringValueFacetCounts}} by ordinal, but the test doesn't know anything about the ordinals, the test breaks ties by the value itself before comparing results. The edge-case is if we only request a topN of 1, but the top result ties in count with other results. In this scenario, the result returned by the {{Facets}} might be one that sorts higher than another when secondarily sorted by value, but the test can't solve for this since it only sees the one result. Should be a fairly simple fix in the test case itself. Will do so shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org