You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/14 15:56:27 UTC
[GitHub] [shardingsphere] jimmyc2006 opened a new pull request #9665: Update CreateTableStatementSchemaRefresher.java
jimmyc2006 opened a new pull request #9665:
URL: https://github.com/apache/shardingsphere/pull/9665
modify the bug #9579
Fixes #9579.
Changes proposed in this pull request:
-
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jimmyc2006 commented on pull request #9665: Update CreateTableStatementSchemaRefresher.java
Posted by GitBox <gi...@apache.org>.
jimmyc2006 commented on pull request #9665:
URL: https://github.com/apache/shardingsphere/pull/9665#issuecomment-799046744
test case problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #9665: Update CreateTableStatementSchemaRefresher.java
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #9665:
URL: https://github.com/apache/shardingsphere/pull/9665#issuecomment-799132005
The empty route result is fixed, the next task is support DDL of encrypt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jimmyc2006 commented on pull request #9665: Update CreateTableStatementSchemaRefresher.java
Posted by GitBox <gi...@apache.org>.
jimmyc2006 commented on pull request #9665:
URL: https://github.com/apache/shardingsphere/pull/9665#issuecomment-799869831
加密规则是不是没必要广播ddl消息，ddl消息只有ShardingRule在监听，如果加面规则同时配置了Sharding规则，那么Sharding规则会发消息的。ShardingSphereEventBus.getInstance().post(CreateTableEvent）好像只有ShardingRule在监听？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jimmyc2006 commented on pull request #9665: Update CreateTableStatementSchemaRefresher.java
Posted by GitBox <gi...@apache.org>.
jimmyc2006 commented on pull request #9665:
URL: https://github.com/apache/shardingsphere/pull/9665#issuecomment-799020514
bad
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jimmyc2006 commented on pull request #9665: Update CreateTableStatementSchemaRefresher.java
Posted by GitBox <gi...@apache.org>.
jimmyc2006 commented on pull request #9665:
URL: https://github.com/apache/shardingsphere/pull/9665#issuecomment-799360446
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #9665: Update CreateTableStatementSchemaRefresher.java
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9665:
URL: https://github.com/apache/shardingsphere/pull/9665#issuecomment-798937133
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9665?src=pr&el=h1) Report
> Merging [#9665](https://codecov.io/gh/apache/shardingsphere/pull/9665?src=pr&el=desc) (4d224f4) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d234904894cd906e225a33eb1db3e641227a25ab?el=desc) (d234904) will **decrease** coverage by `0.00%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/9665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9665 +/- ##
============================================
- Coverage 67.18% 67.18% -0.01%
Complexity 673 673
============================================
Files 1659 1659
Lines 27639 27640 +1
Branches 4912 4913 +1
============================================
Hits 18570 18570
Misses 7711 7711
- Partials 1358 1359 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9665?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...sher/type/CreateTableStatementSchemaRefresher.java](https://codecov.io/gh/apache/shardingsphere/pull/9665/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvcmVmcmVzaGVyL3R5cGUvQ3JlYXRlVGFibGVTdGF0ZW1lbnRTY2hlbWFSZWZyZXNoZXIuamF2YQ==) | `50.00% <50.00%> (-3.85%)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9665?src=pr&el=footer). Last update [d234904...4d224f4](https://codecov.io/gh/apache/shardingsphere/pull/9665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jimmyc2006 closed pull request #9665: Update CreateTableStatementSchemaRefresher.java
Posted by GitBox <gi...@apache.org>.
jimmyc2006 closed pull request #9665:
URL: https://github.com/apache/shardingsphere/pull/9665
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jimmyc2006 closed pull request #9665: Update CreateTableStatementSchemaRefresher.java
Posted by GitBox <gi...@apache.org>.
jimmyc2006 closed pull request #9665:
URL: https://github.com/apache/shardingsphere/pull/9665
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org