You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by mattyb149 <gi...@git.apache.org> on 2016/03/11 15:47:52 UTC
[GitHub] nifi pull request: NIFI-1619: Fix Elasticsearch processor bug when...
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/269
NIFI-1619: Fix Elasticsearch processor bug when flow file missing ID attribute
When the flow file was missing the attribute specified in the processor config, there was still an attempt to insert it into Elasticsearch. This was a simple missing "else" clause. However the flow files that had already been transferred to failure due to this condition caused other problems of multiple transfers. The fix is to keep track of the flow files that remain to be transferred, starting with the original list and removing them as they are transferred.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-1619
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/269.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #269
----
commit bbf2c26fa38e1e3bd742a12ae34ad5bd1982889a
Author: Matt Burgess <ma...@gmail.com>
Date: 2016-03-11T14:44:15Z
NIFI-1619: Fix Elasticsearch processor bug when flow file missing ID attribute
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1619: Fix Elasticsearch processor bug when...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/269#issuecomment-195440926
good point, I just added one. Verified it failed on master, and passes with the fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1619: Fix Elasticsearch processor bug when...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/269#issuecomment-195420771
reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1619: Fix Elasticsearch processor bug when...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/269
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1619: Fix Elasticsearch processor bug when...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/269#issuecomment-195444057
Awesome, thanks. Will let Travis do its thing and get this merged in. Thanks for patching this up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1619: Fix Elasticsearch processor bug when...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/269#issuecomment-195438823
Overall, looks good, was able to use it in conjunction with an ES docker image and things seem to work as anticipated. Would be nice to see a unit test capture the bug that crept up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---