[GitHub] [spark] hddong commented on a change in pull request #30684: [SPARK-33720][K8S] Support submit to k8s only with token

[GitBox <gi...@apache.org>]

hddong commented on a change in pull request #30684:
URL: https://github.com/apache/spark/pull/30684#discussion_r560052449



##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -392,6 +392,13 @@ private[spark] object Config extends Logging {
   val KUBERNETES_AUTH_SUBMISSION_CONF_PREFIX =
     "spark.kubernetes.authenticate.submission"
 
+  val KUBERNETES_TRUST_CERTIFICATES =
+    ConfigBuilder("spark.kubernetes.trust.certificates")
+      .doc("If set to true then client can submit to kubernetes cluster only with token")
+      .version("3.2.0")
+      .booleanConf
+      .createWithDefault(false)

Review comment:
       > For the security, shall we make this `true` by default? For the users who don't have `ca`, they can use `spark.kubernetes.trust.certificates=false` explicitly, @hddong ?
   
   `false` means need `ca`, so default value is what you expect.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org