You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/10/03 00:27:54 UTC
Review Request 38967: Added functionality to generate Java V1
Protobufs and insert them into the existing JAR for now
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38967/
-----------------------------------------------------------
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-3575
https://issues.apache.org/jira/browse/MESOS-3575
Repository: mesos
Description
-------
For now , till we find out a way on how we go about distributing the V1 protobufs. This fail-safe change dumps them into the existing MESOS JAR(Java). This would save anyone the trouble of generating them before using the new API.
Diffs
-----
src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805
Diff: https://reviews.apache.org/r/38967/diff/
Testing
-------
Verified Java JAR has the required protobufs.
Thanks,
Anand Mazumdar
Re: Review Request 38967: Added functionality to generate Java V1
Protobufs and insert them into the existing JAR for now
Posted by Anand Mazumdar <ma...@gmail.com>.
> On Oct. 2, 2015, 10:34 p.m., Isabel Jimenez wrote:
> > src/Makefile.am, line 225
> > <https://reviews.apache.org/r/38967/diff/1/?file=1089142#file1089142line225>
> >
> > Could you also add a fix for v1 python proto generation?
Checkout my comment here : https://issues.apache.org/jira/browse/MESOS-3575
This patch only takes care of Java for now.
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38967/#review101385
-----------------------------------------------------------
On Oct. 2, 2015, 10:27 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38967/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 10:27 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3575
> https://issues.apache.org/jira/browse/MESOS-3575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For now , till we find out a way on how we go about distributing the V1 protobufs. This fail-safe change dumps them into the existing MESOS JAR(Java). This would save anyone the trouble of generating them before using the new API.
>
>
> Diffs
> -----
>
> src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805
>
> Diff: https://reviews.apache.org/r/38967/diff/
>
>
> Testing
> -------
>
> Verified Java JAR has the required protobufs.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38967: Added functionality to generate Java V1
Protobufs and insert them into the existing JAR for now
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38967/#review101385
-----------------------------------------------------------
src/Makefile.am (line 225)
<https://reviews.apache.org/r/38967/#comment158761>
Could you also add a fix for v1 python proto generation?
- Isabel Jimenez
On Oct. 2, 2015, 10:27 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38967/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 10:27 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3575
> https://issues.apache.org/jira/browse/MESOS-3575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For now , till we find out a way on how we go about distributing the V1 protobufs. This fail-safe change dumps them into the existing MESOS JAR(Java). This would save anyone the trouble of generating them before using the new API.
>
>
> Diffs
> -----
>
> src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805
>
> Diff: https://reviews.apache.org/r/38967/diff/
>
>
> Testing
> -------
>
> Verified Java JAR has the required protobufs.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38967: Added functionality to generate Java V1
Protobufs and insert them into the existing JAR for now
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38967/#review101392
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38967]
All tests passed.
- Mesos ReviewBot
On Oct. 2, 2015, 10:27 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38967/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 10:27 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3575
> https://issues.apache.org/jira/browse/MESOS-3575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For now , till we find out a way on how we go about distributing the V1 protobufs. This fail-safe change dumps them into the existing MESOS JAR(Java). This would save anyone the trouble of generating them before using the new API.
>
>
> Diffs
> -----
>
> src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805
>
> Diff: https://reviews.apache.org/r/38967/diff/
>
>
> Testing
> -------
>
> Verified Java JAR has the required protobufs.
>
>
> Thanks,
>
> Anand Mazumdar
>
>