You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/24 02:39:24 UTC

[GitHub] [shardingsphere] TeslaCN opened a new pull request #10167: Replace magic values with enums for PostgreSQLErrorResponsePacket

TeslaCN opened a new pull request #10167:
URL: https://github.com/apache/shardingsphere/pull/10167


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #10167: Replace magic values with enums in PostgreSQLErrorResponsePacket

Posted by GitBox <gi...@apache.org>.

tristaZero merged pull request #10167:
URL: https://github.com/apache/shardingsphere/pull/10167


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #10167: Replace magic values with enums in PostgreSQLErrorResponsePacket

Posted by GitBox <gi...@apache.org>.

tristaZero commented on pull request #10167:
URL: https://github.com/apache/shardingsphere/pull/10167#issuecomment-826022990


   Hi this pr basically looks fine, but I suggest renaming 'newBuilder'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org