You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/22 02:40:17 UTC

[GitHub] [skywalking-rocketbot-ui] Fine0830 opened a new pull request #509: fix: update selector keys for duplicate options

Fine0830 opened a new pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509


   Fixes https://github.com/apache/skywalking/issues/7147#issuecomment-864915908
   
   Screenshots
   ![1](https://user-images.githubusercontent.com/20871783/122854270-0893af80-d346-11eb-9c56-e85e9efb7063.png)
   ![2](https://user-images.githubusercontent.com/20871783/122854275-0af60980-d346-11eb-89b9-3dfd9aa20678.png)
   
   Signed-off-by: Qiuxia Fan <qi...@apache.org>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-869337046


   > I have checked the index data in ES .  the SW_SERVICE_TRAFFIC index automatically delete the previous history data? But I found that the data of the  yesterday did not trigger deletion, This will trigger a duplicate error?
   
   No, it isn't. Once it exists, it should not be inserted again. That is what I mean you ES has issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] start1943 commented on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
start1943 commented on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-869325307


   when SERVER_TRAFFIC index have duplicate data, in trace tab ,choose service is still have problem,Is Dashboard compatible with this situation? @Fine0830 @wu-sheng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] start1943 removed a comment on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
start1943 removed a comment on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-865667748


   ![image](https://user-images.githubusercontent.com/35452394/122881730-0b09ff80-d36e-11eb-83c4-41f851b6dceb.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] start1943 commented on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
start1943 commented on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-865667748


   ![image](https://user-images.githubusercontent.com/35452394/122881730-0b09ff80-d36e-11eb-83c4-41f851b6dceb.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] start1943 edited a comment on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
start1943 edited a comment on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-865667544






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] start1943 edited a comment on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
start1943 edited a comment on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-865667544


   Since I deleted the SERVER_TRAFFIC index yesterday to fix the duplicate data, I cannot test whether the service option conflict is still a problem, but I find that the endpoint selection is still a problem. Selecting a keyword to query the page will still get stuck.There is no option select on endpoints  at the version 8.2
   ![image](https://user-images.githubusercontent.com/35452394/122882087-6c31d300-d36e-11eb-8c5a-a03fa20c4387.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-869337452


   SERVER_TRAFFIC is not an index, it is a template.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] start1943 commented on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
start1943 commented on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-869342070


   yes,i know, There are a lot of duplicate data between the index data of my ES index today and yesterday, and the data in the previous index were all 0, so I guess may be automatically delete the previous history data? In short, is Dashboard compatible with this exception。。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] start1943 commented on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
start1943 commented on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-869333379


   I have checked the index data in ES .  the SW_SERVICE_TRAFFIC index automatically delete the previous history data? But I found that the data of the  yesterday did not trigger deletion, This will trigger a duplicate error?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] start1943 commented on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
start1943 commented on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-865667544






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] start1943 removed a comment on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
start1943 removed a comment on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-865667748


   ![image](https://user-images.githubusercontent.com/35452394/122881730-0b09ff80-d36e-11eb-83c4-41f851b6dceb.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-865483958






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-865483958


   @start1943  You could test this, but still, your ElasticSearch issue should be paid attention to.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] start1943 commented on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
start1943 commented on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-865679184


   I know, that the above img was built and tested with the latest master code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] start1943 edited a comment on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
start1943 edited a comment on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-869342070


   yes,i know, SERVER_TRAFFIC means SERVER_TRAFFIC_{YYYY-MM-DD} index,There are a lot of duplicate data between the index data of my ES index today and yesterday, and the data in the previous index were all 0, so I guess may be automatically delete the previous history data? In short, is Dashboard compatible with this exception。。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-869354890


   Please don't keep saying things repeatedly.
   I am really frustrated to track here, as you never take a look at what I said, and give a feedback.
   I am out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] start1943 commented on pull request #509: fix: update selector keys for duplicate options

Posted by GitBox <gi...@apache.org>.
start1943 commented on pull request #509:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/509#issuecomment-865667544


   Since I deleted the SERVER_TRAFFIC index yesterday to fix the duplicate data, I cannot test whether the service option conflict is still a problem, but I find that the endpoint selection is still a problem. Selecting a keyword to query the page will still get stuck.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org