You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2014/10/07 23:02:34 UTC

[jira] [Commented] (OPTIQ-434) FilterAggregateTransposeRule loses conditions that cannot be pushed

    [ https://issues.apache.org/jira/browse/OPTIQ-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162521#comment-14162521 ] 

Julian Hyde commented on OPTIQ-434:
-----------------------------------

[~pxiong] A few review comments. Can you submit a new patch with these fixed.

1. There are a few spurious diffs, where lines have been re-formatted for no reason. Can you remove these.

2. In RelOptRulesTest.xml, the SQL for testPushFilterWithRank has been changed. Is there a good reason for this? If not please back out.

3. Please rename the variable "conditionsRemain" to "remainingConditions" so that it is consistent with "pushedConditions".

> FilterAggregateTransposeRule loses conditions that cannot be pushed
> -------------------------------------------------------------------
>
>                 Key: OPTIQ-434
>                 URL: https://issues.apache.org/jira/browse/OPTIQ-434
>             Project: Optiq
>          Issue Type: Bug
>            Reporter: Pengcheng Xiong
>            Assignee: Julian Hyde
>            Priority: Critical
>         Attachments: OPTIQ-434.1.patch
>
>
> current FilterAggregateTransposeRule is not correct. the predicates that can not pass agg will disappear silently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)