[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #131: Better HttpVersion and ProtocolVersion.

[GitBox <gi...@apache.org>]

ok2c commented on a change in pull request #131: Better HttpVersion and ProtocolVersion.
URL: https://github.com/apache/httpcomponents-core/pull/131#discussion_r294012945
 
 

 ##########
 File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpVersion.java
 ##########
 @@ -81,36 +101,22 @@ public HttpVersion(final int major, final int minor) {
         super(HTTP, major, minor);
     }
 
-
     /**
      * Obtains a specific HTTP version.
      *
      * @param major     the major version
      * @param minor     the minor version
      *
-     * @return  an instance of {@link HttpVersion} with the argument version
+     * @return an instance of {@link HttpVersion} with the argument version
+     * @throws IllegalArgumentException if either major or minor version number is negative
      */
     @Override
     public ProtocolVersion forVersion(final int major, final int minor) {
 
 Review comment:
   @garydgregory I think `forVersion` method should be removed. It not being used anywhere in the productive code and has been rendered superfluous by static `get` method.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org