You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/15 06:46:09 UTC
[GitHub] [doris] Kikyou1997 opened a new pull request, #14279: [fix](planner) Statistics inaccurate
Kikyou1997 opened a new pull request, #14279:
URL: https://github.com/apache/doris/pull/14279
# Proposed changes
Issue Number: noissue
## Problem summary
If a table already been analyzed, then we analyze it again, the new statistics would larger than expected since the incremental would contain the value from table level statistics since the SQL lack the predication for the nullability of part_id
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #14279: [fix](statistics) statistics inaccurate after analyze same table more than once
Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #14279:
URL: https://github.com/apache/doris/pull/14279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #14279: [fix](planner) Statistics inaccurate
Posted by GitBox <gi...@apache.org>.
Kikyou1997 commented on code in PR #14279:
URL: https://github.com/apache/doris/pull/14279#discussion_r1022381900
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisJob.java:
##########
@@ -124,7 +124,8 @@ private void init(AnalysisJobInfo info) {
+ " FROM ${internalDB}.${columnStatTbl}"
+ " WHERE ${internalDB}.${columnStatTbl}.db_id = '${dbId}' AND "
+ " ${internalDB}.${columnStatTbl}.tbl_id='${tblId}' AND "
- + " ${internalDB}.${columnStatTbl}.col_id='${colId}'"
+ + " ${internalDB}.${columnStatTbl}.col_id='${colId}' AND "
+ + " NOT ISNULL(${internalDB}.${columnStatTbl}.part_id)"
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14279: [fix](planner) Statistics inaccurate
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14279:
URL: https://github.com/apache/doris/pull/14279#issuecomment-1314889528
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.5 seconds
load time: 496 seconds
storage size: 17171348271 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221115072215_clickbench_pr_46199.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #14279: [fix](planner) Statistics inaccurate
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #14279:
URL: https://github.com/apache/doris/pull/14279#discussion_r1022378244
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisJob.java:
##########
@@ -124,7 +124,8 @@ private void init(AnalysisJobInfo info) {
+ " FROM ${internalDB}.${columnStatTbl}"
+ " WHERE ${internalDB}.${columnStatTbl}.db_id = '${dbId}' AND "
+ " ${internalDB}.${columnStatTbl}.tbl_id='${tblId}' AND "
- + " ${internalDB}.${columnStatTbl}.col_id='${colId}'"
+ + " ${internalDB}.${columnStatTbl}.col_id='${colId}' AND "
+ + " NOT ISNULL(${internalDB}.${columnStatTbl}.part_id)"
Review Comment:
parid IS NOT NULL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org