You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2023/11/18 16:49:21 UTC
[PR] [fix](join) incorrect result of left join with other conjuncts [doris]
mrhhsg opened a new pull request, #27238:
URL: https://github.com/apache/doris/pull/27238
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #27238:
URL: https://github.com/apache/doris/pull/27238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817679920
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817569081
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817567952
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817679807
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817736876
TeamCity be ut coverage result:
Function Coverage: 36.75% (8434/22952)
Line Coverage: 29.25% (68616/234588)
Region Coverage: 27.85% (35469/127352)
Branch Coverage: 24.59% (18103/73616)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e3890b8b148d4a07b596f1d40d06f14633360896_e3890b8b148d4a07b596f1d40d06f14633360896/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817740797
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817680560
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817719246
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817708265
TeamCity be ut coverage result:
Function Coverage: 36.74% (8433/22952)
Line Coverage: 29.25% (68613/234588)
Region Coverage: 27.85% (35464/127352)
Branch Coverage: 24.59% (18100/73616)
Coverage Report: http://coverage.selectdb-in.cc/coverage/077503922d4ea83e7c2023984aa9ebbb9c6eee53_077503922d4ea83e7c2023984aa9ebbb9c6eee53/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817713393
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 077503922d4ea83e7c2023984aa9ebbb9c6eee53, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4874 4654 4625 4625
q2 360 157 163 157
q3 2017 1913 1902 1902
q4 1390 1265 1247 1247
q5 3949 3919 3999 3919
q6 251 127 131 127
q7 1388 876 898 876
q8 2782 2776 2746 2746
q9 9971 9386 9342 9342
q10 3488 3502 3506 3502
q11 383 259 244 244
q12 450 295 296 295
q13 4584 3848 3789 3789
q14 306 282 287 282
q15 587 518 528 518
q16 677 583 588 583
q17 1131 967 918 918
q18 7924 7556 7577 7556
q19 1656 1673 1664 1664
q20 548 344 286 286
q21 4408 3997 4013 3997
q22 480 376 381 376
Total cold run time: 53604 ms
Total hot run time: 48951 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4609 4582 4630 4582
q2 350 239 245 239
q3 4048 4005 4025 4005
q4 2712 2693 2708 2693
q5 9567 9572 9616 9572
q6 250 118 125 118
q7 3031 2489 2524 2489
q8 4431 4447 4439 4439
q9 12860 12779 12838 12779
q10 4011 4126 4155 4126
q11 759 699 700 699
q12 975 819 796 796
q13 4269 3564 3563 3563
q14 366 347 346 346
q15 568 522 515 515
q16 748 689 674 674
q17 3849 3882 3880 3880
q18 9745 9070 9084 9070
q19 1814 1783 1759 1759
q20 2394 2052 2077 2052
q21 8871 8708 8648 8648
q22 880 832 791 791
Total cold run time: 81107 ms
Total hot run time: 77835 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817716755
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.95 seconds
stream load tsv: 567 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17099132426 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg closed pull request #27238: [fix](join) incorrect result of left join with other conjuncts
URL: https://github.com/apache/doris/pull/27238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817719800
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817740008
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.94 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.5 seconds inserted 10000000 Rows, about 350K ops/s
storage size: 17098862231 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817738146
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit e3890b8b148d4a07b596f1d40d06f14633360896, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4899 4669 4661 4661
q2 359 155 159 155
q3 2025 1948 1890 1890
q4 1407 1253 1233 1233
q5 3903 3971 3999 3971
q6 249 125 134 125
q7 1410 880 903 880
q8 2769 2783 2760 2760
q9 9814 9459 9428 9428
q10 3462 3506 3498 3498
q11 382 256 249 249
q12 435 295 294 294
q13 4549 3823 3766 3766
q14 314 285 303 285
q15 582 538 520 520
q16 674 594 574 574
q17 1124 978 945 945
q18 7991 7399 7523 7399
q19 1672 1662 1635 1635
q20 592 319 311 311
q21 4425 3989 4004 3989
q22 483 375 365 365
Total cold run time: 53520 ms
Total hot run time: 48933 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4584 4527 4574 4527
q2 337 231 267 231
q3 4030 4018 4018 4018
q4 2707 2695 2711 2695
q5 9608 9545 9603 9545
q6 250 122 127 122
q7 3039 2463 2470 2463
q8 4464 4472 4449 4449
q9 12934 12783 12750 12750
q10 4039 4119 4152 4119
q11 813 637 675 637
q12 976 827 812 812
q13 4249 3547 3538 3538
q14 383 343 339 339
q15 573 513 510 510
q16 733 663 705 663
q17 3877 3962 3815 3815
q18 9571 8956 9135 8956
q19 1792 1781 1762 1762
q20 2413 2065 2046 2046
q21 8890 8693 8536 8536
q22 883 808 843 808
Total cold run time: 81145 ms
Total hot run time: 77341 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817740802
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](join) incorrect result of left join with other conjuncts [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #27238:
URL: https://github.com/apache/doris/pull/27238#issuecomment-1817718767
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org