You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/08/24 10:36:34 UTC
[GitHub] [activemq-artemis] gtully commented on a diff in pull request #4185: ARTEMIS-3943 Adjusting defalut address settings to avoid OME from paging and flow control
gtully commented on code in PR #4185:
URL: https://github.com/apache/activemq-artemis/pull/4185#discussion_r953633059
##########
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/broker.xml:
##########
@@ -144,10 +144,14 @@ ${cluster-security.settings}${cluster.settings}${replicated.settings}${shared-st
<!-- the size of each file on paging. Notice we keep files in memory while they are in use.
Lower this setting if you have too many queues in memory. -->
<page-size-bytes>10M</page-size-bytes>
- <!-- how many messages are kept in memory from paging. The system will stop reading whenever this or max-read-page-bytes hits the max first. -->
- <max-read-page-messages>1000</max-read-page-messages>
+ <!-- how many messages are kept in memory from paging. The system will stop reading whenever this or max-read-page-bytes hits the max first.
+ Change it to a positive value if you want to limit the number of messages read.-->
+ <max-read-page-messages>-1</max-read-page-messages>
<!-- how many bytes equivalent of messages are kept in memory from paging (based on memory estimate). The system will stop reading whenever this or max-read-page-messages hits the max first. -->
<max-read-page-bytes>1M</max-read-page-bytes>
+ <!-- The system will not read any more messages if messages are pending acks.
+ if you set this attribute to false, the broker will allow more reading as soon as messages become on "delivering" state. -->
+ <page-read-flow-control>true</page-read-flow-control>
Review Comment:
I don't see the value in this boolean, if either max-read-page-bytes|messages is set then whether these messages are in the pending or delivering state is irrelevant, they still consume memory/resources on the broker. The only reason to set a max is to protect the broker from memory exhaustion, if speed is the concern then don't limit what can be read at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org