You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Shaofeng SHI (JIRA)" <ji...@apache.org> on 2018/08/02 06:09:00 UTC

[jira] [Resolved] (KYLIN-3146) Response code and exception should be standardised for cube checking

     [ https://issues.apache.org/jira/browse/KYLIN-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shaofeng SHI resolved KYLIN-3146.
---------------------------------
    Resolution: Fixed

> Response code and exception should be standardised for cube checking   
> -----------------------------------------------------------------------
>
>                 Key: KYLIN-3146
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3146
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter:  Kaige Liu
>            Assignee:  Kaige Liu
>            Priority: Minor
>             Fix For: v2.5.0
>
>
> Checking if cubes exist or not is a common behaviour in some APIs. But we have lots of different responses for the same behaviour.
> Let's take CubeController as an example. When can not find a cube with its name, someone gives a *400* as response code, someone returns *404*, and others send back a *500*. Not only HTTP response code is not standard, which kind of exception should be thrown is not unified as well. Still using the above example, we can find *IllegalArgumentException*, *BadRequestException*, *InternalErrorException*.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)