You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by vs...@apache.org on 2009/08/13 14:26:49 UTC

svn commit: r803860 - in /maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd: CpdReportGenerator.java PmdReportListener.java

Author: vsiveton
Date: Thu Aug 13 12:26:49 2009
New Revision: 803860

URL: http://svn.apache.org/viewvc?rev=803860&view=rev
Log:
MPMD-105: Review the Doxia Sink calls

o fixed calls

Modified:
    maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java
    maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java

Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java?rev=803860&r1=803859&r2=803860&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java Thu Aug 13 12:26:49 2009
@@ -91,9 +91,10 @@
         sink.text( " " + PMD.VERSION + "." );
         sink.paragraph_();
 
+        sink.section1_();
+
         // TODO overall summary
 
-        sink.section1_();
         sink.section1();
         sink.sectionTitle1();
         sink.text( bundle.getString( "report.cpd.dupes" ) );
@@ -199,8 +200,6 @@
             }
             sink.tableCell();
 
-
-
             if ( xrefLocation != null )
             {
                 sink.link( xrefLocation2 + "/" + filename2.replaceAll( "\\.java$", ".html" ).replace( '\\', '/' )

Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java?rev=803860&r1=803859&r2=803860&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java Thu Aug 13 12:26:49 2009
@@ -192,9 +192,10 @@
         sink.text( " " + PMD.VERSION + "." );
         sink.paragraph_();
 
+        sink.section1_();
+
         // TODO overall summary
 
-        sink.section1_();
         sink.section1();
         sink.sectionTitle1();
         sink.text( bundle.getString( "report.pmd.files" ) );
@@ -284,7 +285,9 @@
     {
         if ( fileCount == 0 )
         {
+            sink.paragraph();
             sink.text( bundle.getString( "report.pmd.noProblems" ) );
+            sink.paragraph_();
         }
 
         sink.section1_();