[GitHub] [kafka] showuon commented on a diff in pull request #13679: KAFKA-14291: KRaft controller should return right finalized features in ApiVersionResponse

["showuon (via GitHub)" <gi...@apache.org>]

showuon commented on code in PR #13679:
URL: https://github.com/apache/kafka/pull/13679#discussion_r1188407891


##########
core/src/main/scala/kafka/server/ApiVersionManager.scala:
##########
@@ -80,7 +81,18 @@ class SimpleApiVersionManager(
   private val apiVersions = ApiVersionsResponse.collectApis(enabledApis.asJava, enableUnstableLastVersion)
 
   override def apiVersionResponse(requestThrottleMs: Int): ApiVersionsResponse = {
-    ApiVersionsResponse.createApiVersionsResponse(requestThrottleMs, apiVersions, brokerFeatures, zkMigrationEnabled)
+    throw new UnsupportedOperationException("This method is not supported in SimpleApiVersionManager, use apiVersionResponse(throttleTimeMs, finalizedFeatures, epoch) instead")

Review Comment:
   Actually it's not clear when to use `SimpleApiVersionManager` and when to use `DefaultApiVersionManager`. Could we add some comments above each class?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org