You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/01 12:34:03 UTC
[GitHub] [flink] gaoyunhaii commented on a change in pull request #15055: [FLINK-21086][runtime][checkpoint] Support checkpoint alignment with finished input channels
gaoyunhaii commented on a change in pull request #15055:
URL: https://github.com/apache/flink/pull/15055#discussion_r662248379
##########
File path: flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/output/BoundedStreamTask.java
##########
@@ -106,7 +106,8 @@ protected void processInput(MailboxDefaultAction.Controller controller) throws E
mainOperator.processElement(streamRecord);
} else {
mainOperator.endInput();
- controller.allActionsCompleted();
+ controller.suspendDefaultAction();
Review comment:
I think we might have to suspend the default action, otherwise after resuming the mailbox processor would not blocked on waiting for the next mail in `processMailsWhenDefaultActionUnavailable`, instead it would repeat the loop of check mail exists & run default action, which would be similar to a `while` loop~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org