You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2015/06/13 00:59:31 UTC
Review Request 35405: Enable deleting MasterDetector in
MesosSchedulerDriver::join.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35405/
-----------------------------------------------------------
Review request for mesos and Niklas Nielsen.
Repository: mesos
Description
-------
This is a proof of concept to help folks out in https://reviews.apache.org/r/33208.
Diffs
-----
src/sched/sched.cpp 9423607b45a1511f6cc3dca873b6ebbca182ebd5
src/tests/mesos.hpp e19ef984f9e4696bd405027d6f19756cf23d0df2
Diff: https://reviews.apache.org/r/35405/diff/
Testing
-------
NOT YET
Thanks,
Benjamin Hindman
Re: Review Request 35405: Enable deleting MasterDetector in
MesosSchedulerDriver::join.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35405/#review88437
-----------------------------------------------------------
src/sched/sched.cpp (line 1659)
<https://reviews.apache.org/r/35405/#comment140952>
s/a bunch //
src/sched/sched.cpp (line 1660)
<https://reviews.apache.org/r/35405/#comment140953>
Should we maybe mention the GC issue with JVM (to get a bit more concrete).
src/sched/sched.cpp (lines 1662 - 1672)
<https://reviews.apache.org/r/35405/#comment140954>
Can you break this comment up a bit. A lot to swallow in one sentence :)
src/sched/sched.cpp (lines 1670 - 1672)
<https://reviews.apache.org/r/35405/#comment140955>
Should we turn that into a JIRA and reference from here?
src/tests/mesos.hpp (line 712)
<https://reviews.apache.org/r/35405/#comment140956>
s/is greater/exceeds/? If it is a notion of time
- Niklas Nielsen
On June 18, 2015, 5:39 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35405/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 5:39 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a proof of concept to help folks out in https://reviews.apache.org/r/33208.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp bc76c71ae9d44bdddd291049223366e38cb0fd0c
> src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3
>
> Diff: https://reviews.apache.org/r/35405/diff/
>
>
> Testing
> -------
>
> NOT YET
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 35405: Enable deleting MasterDetector in
MesosSchedulerDriver::join.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35405/
-----------------------------------------------------------
(Updated June 18, 2015, 12:39 p.m.)
Review request for mesos and Niklas Nielsen.
Repository: mesos
Description
-------
This is a proof of concept to help folks out in https://reviews.apache.org/r/33208.
Diffs (updated)
-----
src/sched/sched.cpp bc76c71ae9d44bdddd291049223366e38cb0fd0c
src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3
Diff: https://reviews.apache.org/r/35405/diff/
Testing
-------
NOT YET
Thanks,
Benjamin Hindman
Re: Review Request 35405: Enable deleting MasterDetector in
MesosSchedulerDriver::join.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35405/#review87794
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35405]
All tests passed.
- Mesos ReviewBot
On June 12, 2015, 11:08 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35405/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 11:08 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a proof of concept to help folks out in https://reviews.apache.org/r/33208.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 9423607b45a1511f6cc3dca873b6ebbca182ebd5
> src/tests/mesos.hpp e19ef984f9e4696bd405027d6f19756cf23d0df2
>
> Diff: https://reviews.apache.org/r/35405/diff/
>
>
> Testing
> -------
>
> NOT YET
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 35405: Enable deleting MasterDetector in
MesosSchedulerDriver::join.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35405/
-----------------------------------------------------------
(Updated June 12, 2015, 11:08 p.m.)
Review request for mesos and Niklas Nielsen.
Repository: mesos
Description
-------
This is a proof of concept to help folks out in https://reviews.apache.org/r/33208.
Diffs (updated)
-----
src/sched/sched.cpp 9423607b45a1511f6cc3dca873b6ebbca182ebd5
src/tests/mesos.hpp e19ef984f9e4696bd405027d6f19756cf23d0df2
Diff: https://reviews.apache.org/r/35405/diff/
Testing
-------
NOT YET
Thanks,
Benjamin Hindman