You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zhongqiangczq (via GitHub)" <gi...@apache.org> on 2023/06/25 08:34:47 UTC
[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1621: [CELEBORN-712] Make appUniqueId a member of ShuffleClientImpl and refactor code
zhongqiangczq commented on code in PR #1621:
URL: https://github.com/apache/incubator-celeborn/pull/1621#discussion_r1241091485
##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/readclient/FlinkShuffleClientImpl.java:
##########
@@ -130,17 +135,14 @@ public FlinkShuffleClientImpl(
new FlinkTransportClientFactory(context, conf.clientFetchMaxRetriesForEachReplica());
this.setupMetaServiceRef(driverHost, port);
this.driverTimestamp = driverTimestamp;
+ this.appUniqueId = appUniqueId;
Review Comment:
appUniqueId can be removed from FlinkShuffleClientImpl if appUniqueId access is set `protected` in parent class ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org