You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "emilk (via GitHub)" <gi...@apache.org> on 2025/09/15 09:33:15 UTC

[PR] Use `Display` formatting of `DataType`:s in error messagwe [datafusion]

emilk opened a new pull request, #17565:
URL: https://github.com/apache/datafusion/pull/17565

   * Related: https://github.com/apache/arrow-rs/pull/8290
   
   ## Rationale for this change
   I believe that error messages should be as readable as possible. Aim for `rustc` more than `gcc`.
   
   `Display` is the nice, user-facing formatter. Debug is for… well, debugging.
   
   ## What changes are included in this PR?
   Change a bunch of `{:?}` format string to `{}`. I'm sure I missed a lot of them, because I know of no way to enforce this without
   * https://github.com/rust-lang/rust-clippy/issues/8581
   
   ## Are these changes tested?
   I assume CI runs `cargo test` :)
   
   ## Are there any user-facing changes?
   Yes! Error messages should be a bit more readable now, especially once this lands: 
   
   * https://github.com/apache/arrow-rs/pull/8290


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Use `Display` formatting of `DataType`:s in error messagwe [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #17565:
URL: https://github.com/apache/datafusion/pull/17565#issuecomment-3292252841

   > I recommend running cargo test locally first to catch all the test errors and fix them in one go, in case you're not already doing so
   
   
   My personal favorite is `cargo nextest run`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Use `Display` formatting of `DataType`:s in error messages [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #17565:
URL: https://github.com/apache/datafusion/pull/17565#issuecomment-3304670794

   Thank you very much @emilk and @timsaucer 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Use `Display` formatting of `DataType`:s in error messagwe [datafusion]

Posted by "emilk (via GitHub)" <gi...@apache.org>.
emilk commented on PR #17565:
URL: https://github.com/apache/datafusion/pull/17565#issuecomment-3291861998

   Should be green now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Use `Display` formatting of `DataType`:s in error messagwe [datafusion]

Posted by "emilk (via GitHub)" <gi...@apache.org>.
emilk commented on PR #17565:
URL: https://github.com/apache/datafusion/pull/17565#issuecomment-3292261760

   I did, unfortunately `cargo test` they didn't cover _all_ the test, and `cargo test --all-features` doesn't compile. Apparently CI does something slightly more complex:
   
   https://github.com/rerun-io/arrow-datafusion/blob/e077920b19867d02b43f836c92bfb61183493ea0/.github/workflows/extended.yml#L109-L119


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Use `Display` formatting of `DataType`:s in error messagwe [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #17565:
URL: https://github.com/apache/datafusion/pull/17565#issuecomment-3292241016

   I recommend running `cargo test` locally first to catch all the test errors and fix them in one go, in case you're not already doing so
   
   Relying on CI checks can be slow for iteration


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Use `Display` formatting of `DataType`:s in error messagwe [datafusion]

Posted by "emilk (via GitHub)" <gi...@apache.org>.
emilk commented on PR #17565:
URL: https://github.com/apache/datafusion/pull/17565#issuecomment-3302599103

   OMG IS GREEN


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Use `Display` formatting of `DataType`:s in error messagwe [datafusion]

Posted by "emilk (via GitHub)" <gi...@apache.org>.
emilk commented on PR #17565:
URL: https://github.com/apache/datafusion/pull/17565#issuecomment-3301432574

   Reverted some error messages, and `cargo nextest run` is still green locally…


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Use `Display` formatting of `DataType`:s in error messagwe [datafusion]

Posted by "emilk (via GitHub)" <gi...@apache.org>.
emilk commented on PR #17565:
URL: https://github.com/apache/datafusion/pull/17565#issuecomment-3292563046

   `cargo nextest run` passes on my machine now - let's see what CI says


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Use `Display` formatting of `DataType`:s in error messages [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #17565:
URL: https://github.com/apache/datafusion/pull/17565#issuecomment-3304670465

   gogogogo!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Use `Display` formatting of `DataType`:s in error messages [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #17565:
URL: https://github.com/apache/datafusion/pull/17565


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org