[GitHub] [wicket] theigl commented on a change in pull request #437: WICKET-6795 Avoid splitting and joining ajax event names

[GitBox <gi...@apache.org>]

theigl commented on a change in pull request #437:
URL: https://github.com/apache/wicket/pull/437#discussion_r433136846



##########
File path: wicket-core/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java
##########
@@ -119,11 +119,16 @@ protected void updateAjaxAttributes(AjaxRequestAttributes attributes)
 	 */
 	public String getEvent()
 	{
+		if (event.indexOf(' ') == -1)

Review comment:
       @martin-g: My working assumption was that `\\s+` represents multiple space characters and was not actually intended for for matching tabs and newlines. But you are right, it doesn't look too great. I'll write a quick benchmark to compare performance of both solutions: Alternatively, we could simply look for space in both cases.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org