You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2014/11/05 23:12:07 UTC

Review Request 27642: SQOOP-1682 Test cases *LobAvroImportTest are failing

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27642/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1682
    https://issues.apache.org/jira/browse/SQOOP-1682


Repository: sqoop-trunk


Description
-------

I've mostly reverted changes in SQOOP-1362 and:

* Improved the *LobTestCase to produce more reasonable failure
* Fixed Parqut to also point the lob files to the right location on HDFS instead of temporary directory


Diffs
-----

  src/java/com/cloudera/sqoop/lib/LargeObjectLoader.java 8966579 
  src/java/org/apache/sqoop/lib/LargeObjectLoader.java a0f94d2 
  src/java/org/apache/sqoop/mapreduce/AvroImportMapper.java 1454ead 
  src/java/org/apache/sqoop/mapreduce/HBaseBulkImportMapper.java 10891e9 
  src/java/org/apache/sqoop/mapreduce/ParquetImportMapper.java fb6af2c 
  src/java/org/apache/sqoop/mapreduce/SequenceFileImportMapper.java fde5d66 
  src/java/org/apache/sqoop/mapreduce/TextImportMapper.java f0bca93 
  src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java 598483d 
  src/test/com/cloudera/sqoop/lib/TestLargeObjectLoader.java c6bebf7 
  src/test/com/cloudera/sqoop/testutil/LobAvroImportTestCase.java 199c661 

Diff: https://reviews.apache.org/r/27642/diff/


Testing
-------

Tests seems to be passing.


Thanks,

Jarek Cecho


Re: Review Request 27642: SQOOP-1682 Test cases *LobAvroImportTest are failing

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27642/#review60067
-----------------------------------------------------------

Ship it!


Ship It!

- Abraham Elmahrek


On Nov. 5, 2014, 10:43 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27642/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 10:43 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1682
>     https://issues.apache.org/jira/browse/SQOOP-1682
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> I've mostly reverted changes in SQOOP-1362 and:
> 
> * Improved the *LobTestCase to produce more reasonable failure
> * Fixed Parqut to also point the lob files to the right location on HDFS instead of temporary directory
> 
> 
> Diffs
> -----
> 
>   src/java/com/cloudera/sqoop/lib/LargeObjectLoader.java 8966579 
>   src/java/org/apache/sqoop/lib/LargeObjectLoader.java a0f94d2 
>   src/java/org/apache/sqoop/mapreduce/AvroImportMapper.java 1454ead 
>   src/java/org/apache/sqoop/mapreduce/HBaseBulkImportMapper.java 10891e9 
>   src/java/org/apache/sqoop/mapreduce/ParquetImportMapper.java fb6af2c 
>   src/java/org/apache/sqoop/mapreduce/SequenceFileImportMapper.java fde5d66 
>   src/java/org/apache/sqoop/mapreduce/TextImportMapper.java f0bca93 
>   src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java 598483d 
>   src/test/com/cloudera/sqoop/lib/TestLargeObjectLoader.java c6bebf7 
>   src/test/com/cloudera/sqoop/testutil/LobAvroImportTestCase.java 199c661 
> 
> Diff: https://reviews.apache.org/r/27642/diff/
> 
> 
> Testing
> -------
> 
> Tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request 27642: SQOOP-1682 Test cases *LobAvroImportTest are failing

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27642/
-----------------------------------------------------------

(Updated Nov. 5, 2014, 10:43 p.m.)


Review request for Sqoop.


Changes
-------

Fixing failing HiveImportTest.


Bugs: SQOOP-1682
    https://issues.apache.org/jira/browse/SQOOP-1682


Repository: sqoop-trunk


Description
-------

I've mostly reverted changes in SQOOP-1362 and:

* Improved the *LobTestCase to produce more reasonable failure
* Fixed Parqut to also point the lob files to the right location on HDFS instead of temporary directory


Diffs (updated)
-----

  src/java/com/cloudera/sqoop/lib/LargeObjectLoader.java 8966579 
  src/java/org/apache/sqoop/lib/LargeObjectLoader.java a0f94d2 
  src/java/org/apache/sqoop/mapreduce/AvroImportMapper.java 1454ead 
  src/java/org/apache/sqoop/mapreduce/HBaseBulkImportMapper.java 10891e9 
  src/java/org/apache/sqoop/mapreduce/ParquetImportMapper.java fb6af2c 
  src/java/org/apache/sqoop/mapreduce/SequenceFileImportMapper.java fde5d66 
  src/java/org/apache/sqoop/mapreduce/TextImportMapper.java f0bca93 
  src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java 598483d 
  src/test/com/cloudera/sqoop/lib/TestLargeObjectLoader.java c6bebf7 
  src/test/com/cloudera/sqoop/testutil/LobAvroImportTestCase.java 199c661 

Diff: https://reviews.apache.org/r/27642/diff/


Testing
-------

Tests seems to be passing.


Thanks,

Jarek Cecho