You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by Rafael Schloming <rh...@alum.mit.edu> on 2013/02/20 21:31:11 UTC
0.4 RC2
Source posted here:
- http://people.apache.org/~rhs/qpid-proton-0.4rc2/
Java binaries here:
- https://repository.apache.org/content/repositories/orgapacheqpid-280/
I'd like to call an official vote soon, e.g. tomorrow, so please have a
look and share your results here.
Changes from RC1:
PROTON-199: support python 2.4
PROTON-236 freegetopt compat for proton-c windows builds.
PROTON-243: fixed LIB_SUFFIX magic
PROTON-200: maintain a minimum credit level for each receive link
PROTON-200: make similar changes to Java MessengerImpl
PROTON-200: allow recv(-1) to grant unlimited credit
PROTON-232: described arrays seem to force the descriptor to be of the same
type as the array Fixed bug in code.c pn_data_encode_node: was always using
the parent->type for everything inside an array, including the descriptor.
PROTON-242: Shared library used JNI code has poor name "libproton-swig.so"
Shared library now has name libproton-jni.so i.e. follows the naming
conventions of its companion jar.
PROTON-217: cmake build system should include install target for Java
binaries
--Rafael
Re: 0.4 RC2
Posted by Andrew Stitcher <as...@redhat.com>.
On Thu, 2013-02-21 at 11:01 -0500, Andrew Stitcher wrote:
> On Wed, 2013-02-20 at 12:31 -0800, Rafael Schloming wrote:
> > Source posted here:
> > - http://people.apache.org/~rhs/qpid-proton-0.4rc2/
> >
> > Java binaries here:
> > - https://repository.apache.org/content/repositories/orgapacheqpid-280/
> >
> > I'd like to call an official vote soon, e.g. tomorrow, so please have a
> > look and share your results here.
>
> For my purposes PROTON-246 [1] is blocking, so I'm likely to -1 any
> release until it is fixed. As this screws up attaching filters to links
> and I need this to work in 0.4 so that qpid 0.22 can depend on it.
>
> I am looking at this bug right now, but to be honest the naming scheme
> of the pn_data_* operations is slowing my progress by obscuring what is
> going on.
Ok, thanks to Bozo Dragojevic I have committed a fix for this now.
Andrew
Re: 0.4 RC2
Posted by Andrew Stitcher <as...@redhat.com>.
On Wed, 2013-02-20 at 12:31 -0800, Rafael Schloming wrote:
> Source posted here:
> - http://people.apache.org/~rhs/qpid-proton-0.4rc2/
>
> Java binaries here:
> - https://repository.apache.org/content/repositories/orgapacheqpid-280/
>
> I'd like to call an official vote soon, e.g. tomorrow, so please have a
> look and share your results here.
For my purposes PROTON-246 [1] is blocking, so I'm likely to -1 any
release until it is fixed. As this screws up attaching filters to links
and I need this to work in 0.4 so that qpid 0.22 can depend on it.
I am looking at this bug right now, but to be honest the naming scheme
of the pn_data_* operations is slowing my progress by obscuring what is
going on.
Andrew
[1] https://issues.apache.org/jira/browse/PROTON-246
Re: 0.4 RC2
Posted by Phil Harvey <ph...@philharveyonline.com>.
OK.
I've modified JNIMessenger to throw ProtonUnsupportedOperationException so
testSendBogus skips rather than fails when using the proton-jni profile. I
believe there is still an issue with the pure Java implementation too
because this test fails on my dev machine (though not on the Apache Jenkins
job), therefore I'm leaving PROTON-214 open for now.
I'm easy about whether we mention this stuff in the release notes. Since
PROTON-214 is still open, maybe the existence of that Jira is enough to
flag this deficiency.
On 21 February 2013 21:42, Rafael Schloming <rh...@alum.mit.edu> wrote:
> On Thu, Feb 21, 2013 at 10:53 AM, Rafael Schloming <rh...@alum.mit.edu>
> wrote:
>
> > On Wed, Feb 20, 2013 at 2:43 PM, Phil Harvey <phil@philharveyonline.com
> >wrote:
> >
> >> Mostly looks good. One test is failing when run using the Java JNI
> >> binding
> >> - see below.
> >>
> >> Tested:
> >>
> >> - Download tarball
> >> - cmake, make, make install
> >> - Observed .so and .jar files installed to correct locations
> >> - Ran ./tests/python/proton-test
> >> - Ran mvn package test and observed all tests passing
> >> - Ran mvn -P proton-jni test
> >> - *FAILED* test "proton_tests.messenger.MessengerTest.testSendBogus".
> I
> >> think this is existing issue PROTON-214 [1]. I don't know if this
> >> represents a serious functional problem but generally we wouldn't want
> to
> >> release something that fails any tests.
> >>
> >
> > I looked into this a little bit. The test is checking that using
> messenger
> > to send to an address that contains an unresolvable domain name will
> > actually fail. This appears to work fine with pure Java messenger, fine
> > with pure C messenger, but for some reason doesn't work with Java using C
> > via JNI. This is a bit of a mystery to me as I believe the networking
> code
> > is exactly the same in both cases. This needs a bit more investigation to
> > figure out what is going on, but given how isolated this is I'd prefer
> not
> > to hold up the release if we don't turn up anything fruitful soon.
> >
>
> Ok, mystery solved. My assumption was that the profile was running the Java
> messenger with a JNI wrapped engine. It's actually JNI wrapped the entire C
> messenger impl and JNIMessenger.java doesn't actually check any return
> codes, e.g.:
>
> @Override
> public void put(final Message message) throws MessengerException
> {
> SWIGTYPE_p_pn_message_t message_t = (message instanceof JNIMessage)
> ? ((JNIMessage)message).getImpl() : convertMessage(message);
> int err = Proton.pn_messenger_put(_impl, message_t);
> //TODO - error handling
> }
>
> As this isn't really fixable in an 0.4 timeframe, I think we should just
> release note this issue.
>
> --Rafael
>
Re: 0.4 RC2
Posted by Rafael Schloming <rh...@alum.mit.edu>.
On Thu, Feb 21, 2013 at 10:53 AM, Rafael Schloming <rh...@alum.mit.edu> wrote:
> On Wed, Feb 20, 2013 at 2:43 PM, Phil Harvey <ph...@philharveyonline.com>wrote:
>
>> Mostly looks good. One test is failing when run using the Java JNI
>> binding
>> - see below.
>>
>> Tested:
>>
>> - Download tarball
>> - cmake, make, make install
>> - Observed .so and .jar files installed to correct locations
>> - Ran ./tests/python/proton-test
>> - Ran mvn package test and observed all tests passing
>> - Ran mvn -P proton-jni test
>> - *FAILED* test "proton_tests.messenger.MessengerTest.testSendBogus". I
>> think this is existing issue PROTON-214 [1]. I don't know if this
>> represents a serious functional problem but generally we wouldn't want to
>> release something that fails any tests.
>>
>
> I looked into this a little bit. The test is checking that using messenger
> to send to an address that contains an unresolvable domain name will
> actually fail. This appears to work fine with pure Java messenger, fine
> with pure C messenger, but for some reason doesn't work with Java using C
> via JNI. This is a bit of a mystery to me as I believe the networking code
> is exactly the same in both cases. This needs a bit more investigation to
> figure out what is going on, but given how isolated this is I'd prefer not
> to hold up the release if we don't turn up anything fruitful soon.
>
Ok, mystery solved. My assumption was that the profile was running the Java
messenger with a JNI wrapped engine. It's actually JNI wrapped the entire C
messenger impl and JNIMessenger.java doesn't actually check any return
codes, e.g.:
@Override
public void put(final Message message) throws MessengerException
{
SWIGTYPE_p_pn_message_t message_t = (message instanceof JNIMessage)
? ((JNIMessage)message).getImpl() : convertMessage(message);
int err = Proton.pn_messenger_put(_impl, message_t);
//TODO - error handling
}
As this isn't really fixable in an 0.4 timeframe, I think we should just
release note this issue.
--Rafael
Re: 0.4 RC2
Posted by Rafael Schloming <rh...@alum.mit.edu>.
On Wed, Feb 20, 2013 at 2:43 PM, Phil Harvey <ph...@philharveyonline.com>wrote:
> Mostly looks good. One test is failing when run using the Java JNI binding
> - see below.
>
> Tested:
>
> - Download tarball
> - cmake, make, make install
> - Observed .so and .jar files installed to correct locations
> - Ran ./tests/python/proton-test
> - Ran mvn package test and observed all tests passing
> - Ran mvn -P proton-jni test
> - *FAILED* test "proton_tests.messenger.MessengerTest.testSendBogus". I
> think this is existing issue PROTON-214 [1]. I don't know if this
> represents a serious functional problem but generally we wouldn't want to
> release something that fails any tests.
>
I looked into this a little bit. The test is checking that using messenger
to send to an address that contains an unresolvable domain name will
actually fail. This appears to work fine with pure Java messenger, fine
with pure C messenger, but for some reason doesn't work with Java using C
via JNI. This is a bit of a mystery to me as I believe the networking code
is exactly the same in both cases. This needs a bit more investigation to
figure out what is going on, but given how isolated this is I'd prefer not
to hold up the release if we don't turn up anything fruitful soon.
--Rafael
Re: 0.4 RC2
Posted by Ken Giusti <kg...@redhat.com>.
+1 - I'll push the fix.
-K
----- Original Message -----
> On Thu, Feb 21, 2013 at 6:57 AM, Ken Giusti <kg...@redhat.com>
> wrote:
>
> > make still fails on Centos-5 due to swig parse error. See
> > https://issues.apache.org/jira/browse/PROTON-245
> >
> > I've tried Rafi's suggestion - we could simply ifdef-out the
> > definition
> > when the header is processed by swig:
> >
> > #ifndef SWIG // older versions of SWIG choke on this:
> > static inline pn_delivery_tag_t pn_dtag(const char *bytes, size_t
> > size) {
> > pn_delivery_tag_t dtag = {size, bytes};
> > return dtag;
> > }
> > #endif
> >
> >
> > This seems to work - at least the build completes and all python
> > unit
> > tests pass.
> >
> > Given that this is a inline function, I don't think swig is going
> > to
> > wrap/export it anyways, right?
> >
> > Not that I'm comfortable with the whole "static functions exported
> > via API
> > headers" thing - seems like a recipe for disaster, ABI-wise.
> >
>
> Yeah, I don't think we need swig to see this. I'd say go with this
> for 0.4
> and let's work on a better API for 0.5.
>
> --Rafael
>
Re: 0.4 RC2
Posted by Rafael Schloming <rh...@alum.mit.edu>.
On Thu, Feb 21, 2013 at 6:57 AM, Ken Giusti <kg...@redhat.com> wrote:
> make still fails on Centos-5 due to swig parse error. See
> https://issues.apache.org/jira/browse/PROTON-245
>
> I've tried Rafi's suggestion - we could simply ifdef-out the definition
> when the header is processed by swig:
>
> #ifndef SWIG // older versions of SWIG choke on this:
> static inline pn_delivery_tag_t pn_dtag(const char *bytes, size_t size) {
> pn_delivery_tag_t dtag = {size, bytes};
> return dtag;
> }
> #endif
>
>
> This seems to work - at least the build completes and all python unit
> tests pass.
>
> Given that this is a inline function, I don't think swig is going to
> wrap/export it anyways, right?
>
> Not that I'm comfortable with the whole "static functions exported via API
> headers" thing - seems like a recipe for disaster, ABI-wise.
>
Yeah, I don't think we need swig to see this. I'd say go with this for 0.4
and let's work on a better API for 0.5.
--Rafael
Re: 0.4 RC2
Posted by Ken Giusti <kg...@redhat.com>.
make still fails on Centos-5 due to swig parse error. See https://issues.apache.org/jira/browse/PROTON-245
I've tried Rafi's suggestion - we could simply ifdef-out the definition when the header is processed by swig:
#ifndef SWIG // older versions of SWIG choke on this:
static inline pn_delivery_tag_t pn_dtag(const char *bytes, size_t size) {
pn_delivery_tag_t dtag = {size, bytes};
return dtag;
}
#endif
This seems to work - at least the build completes and all python unit tests pass.
Given that this is a inline function, I don't think swig is going to wrap/export it anyways, right?
Not that I'm comfortable with the whole "static functions exported via API headers" thing - seems like a recipe for disaster, ABI-wise.
-K
----- Original Message -----
> Mostly looks good. One test is failing when run using the Java JNI
> binding
> - see below.
>
> Tested:
>
> - Download tarball
> - cmake, make, make install
> - Observed .so and .jar files installed to correct locations
> - Ran ./tests/python/proton-test
> - Ran mvn package test and observed all tests passing
> - Ran mvn -P proton-jni test
> - *FAILED* test
> "proton_tests.messenger.MessengerTest.testSendBogus". I
> think this is existing issue PROTON-214 [1]. I don't know if this
> represents a serious functional problem but generally we wouldn't
> want to
> release something that fails any tests.
> - Created and ran a simple Maven project that depends on proton-api
> and
> proton-j-impl 0.4 in the
> orgapacheqpid-280/<https://repository.apache.org/content/repositories/orgapacheqpid-280/>
> repo.
>
>
> Environment:
> - Linux Mint 12, x86_64
> - Java: Oracle 1.6.0_29
> - cmake version 2.8.5
> - SWIG Version 1.3.40
> - Python 2.7.2+
>
>
> Phil
>
> [1] https://issues.apache.org/jira/browse/PROTON-214
>
>
>
> On 20 February 2013 20:31, Rafael Schloming <rh...@alum.mit.edu> wrote:
>
> > Source posted here:
> > - http://people.apache.org/~rhs/qpid-proton-0.4rc2/
> >
> > Java binaries here:
> > -
> > https://repository.apache.org/content/repositories/orgapacheqpid-280/
> >
> > I'd like to call an official vote soon, e.g. tomorrow, so please
> > have a
> > look and share your results here.
> >
> > Changes from RC1:
> >
> > PROTON-199: support python 2.4
> > PROTON-236 freegetopt compat for proton-c windows builds.
> > PROTON-243: fixed LIB_SUFFIX magic
> > PROTON-200: maintain a minimum credit level for each receive link
> > PROTON-200: make similar changes to Java MessengerImpl
> > PROTON-200: allow recv(-1) to grant unlimited credit
> > PROTON-232: described arrays seem to force the descriptor to be of
> > the same
> > type as the array Fixed bug in code.c pn_data_encode_node: was
> > always using
> > the parent->type for everything inside an array, including the
> > descriptor.
> > PROTON-242: Shared library used JNI code has poor name
> > "libproton-swig.so"
> > Shared library now has name libproton-jni.so i.e. follows the
> > naming
> > conventions of its companion jar.
> > PROTON-217: cmake build system should include install target for
> > Java
> > binaries
> >
> > --Rafael
> >
>
Re: 0.4 RC2
Posted by Phil Harvey <ph...@philharveyonline.com>.
Mostly looks good. One test is failing when run using the Java JNI binding
- see below.
Tested:
- Download tarball
- cmake, make, make install
- Observed .so and .jar files installed to correct locations
- Ran ./tests/python/proton-test
- Ran mvn package test and observed all tests passing
- Ran mvn -P proton-jni test
- *FAILED* test "proton_tests.messenger.MessengerTest.testSendBogus". I
think this is existing issue PROTON-214 [1]. I don't know if this
represents a serious functional problem but generally we wouldn't want to
release something that fails any tests.
- Created and ran a simple Maven project that depends on proton-api and
proton-j-impl 0.4 in the
orgapacheqpid-280/<https://repository.apache.org/content/repositories/orgapacheqpid-280/>
repo.
Environment:
- Linux Mint 12, x86_64
- Java: Oracle 1.6.0_29
- cmake version 2.8.5
- SWIG Version 1.3.40
- Python 2.7.2+
Phil
[1] https://issues.apache.org/jira/browse/PROTON-214
On 20 February 2013 20:31, Rafael Schloming <rh...@alum.mit.edu> wrote:
> Source posted here:
> - http://people.apache.org/~rhs/qpid-proton-0.4rc2/
>
> Java binaries here:
> - https://repository.apache.org/content/repositories/orgapacheqpid-280/
>
> I'd like to call an official vote soon, e.g. tomorrow, so please have a
> look and share your results here.
>
> Changes from RC1:
>
> PROTON-199: support python 2.4
> PROTON-236 freegetopt compat for proton-c windows builds.
> PROTON-243: fixed LIB_SUFFIX magic
> PROTON-200: maintain a minimum credit level for each receive link
> PROTON-200: make similar changes to Java MessengerImpl
> PROTON-200: allow recv(-1) to grant unlimited credit
> PROTON-232: described arrays seem to force the descriptor to be of the same
> type as the array Fixed bug in code.c pn_data_encode_node: was always using
> the parent->type for everything inside an array, including the descriptor.
> PROTON-242: Shared library used JNI code has poor name "libproton-swig.so"
> Shared library now has name libproton-jni.so i.e. follows the naming
> conventions of its companion jar.
> PROTON-217: cmake build system should include install target for Java
> binaries
>
> --Rafael
>
Re: 0.4 RC2
Posted by Keith W <ke...@gmail.com>.
Hi Paul
I've successfuly reproduced your issue and are tracking our progress
under PROTON-249. We don't need your debug output at this stage.
Kind regards, Keith.
On 24 February 2013 00:27, Paul O'Fallon <pa...@ofallonfamily.com> wrote:
> I filed this as https://issues.apache.org/jira/browse/PROTON-249
>
> I have some files to attach (my cmake debug output and the vs2012 build
> output) but I couldn't see in Jira where to attach the files (maybe I don't
> have permission?)
>
> Thanks,
> Paul
>
>
> On Sat, Feb 23, 2013 at 3:04 PM, Paul O'Fallon <pa...@ofallonfamily.com>
> wrote:
>>
>> Sure, I'll do that. This error is from the VS 2012 build output (cmake
>> runs with no errors). I'm running v. 2.8.10.2 of cmake.
>>
>> I know with other projects I've run into issues when the depth of
>> directories on Windows grows too large -- not sure if this structure is that
>> deep yet (although that's why I moved it to the root dir of my machine to
>> give it the best shot of working).
>>
>> - Paul
>>
>>
>> On Sat, Feb 23, 2013 at 2:35 PM, Keith Wall <ke...@gmail.com> wrote:
>>>
>>>
>>>
>>> I'm getting much closer I
>>>
>>> still get one error
>>>
>>> 4> javac: file not found:
>>>
>>>
>>> C:\qpid-proton-0.4\proton-j\proton-api\src\main\java\org\apache\qpi\proton\driver\Connector.java
>>> 4> Usage: javac <options> <source files>
>>> 4> use -help for a list of possible options
>>>
>>> Paul,
>>>
>>> That sounds odd. The proton-api cmakelist is really simple so I wonder
>>> what we might be doing wrong to cause such an error. We have nothing that
>>> manipulates the paths.
>>>
>>> Would you be able to repeat with cmake in verbose/debug mode (sorry I
>>> forget the precise name of the cmake option and am travelling right now) and
>>> attach the output to a new Jira, What version of cmake are you using?
>>> What exact commands are you issuing to get the error?
>>>
>>> Kind regards. Keith.
>>>
>>>
>>
>
Re: 0.4 RC2
Posted by Keith Wall <ke...@gmail.com>.
> I'm getting much closer I
> still get one error
> 4> javac: file not found:
C:\qpid-proton-0.4\proton-j\proton-api\src\main\java\org\apache\qpi\proton\driver\Connector.java
4> Usage: javac <options> <source files>
4> use -help for a list of possible options
Paul,
That sounds odd. The proton-api cmakelist is really simple so I wonder what we might be doing wrong to cause such an error. We have nothing that manipulates the paths.
Would you be able to repeat with cmake in verbose/debug mode (sorry I forget the precise name of the cmake option and am travelling right now) and attach the output to a new Jira, What version of cmake are you using? What exact commands are you issuing to get the error?
Kind regards. Keith.
Re: 0.4 RC2
Posted by Paul O'Fallon <pa...@ofallonfamily.com>.
Thanks! I moved by build up to the top level directory (and the overall
project to the root dir of my machine) and while I'm getting much closer I
still get one error. Here is the relevant error from the build output:
4> Building Java objects for proton-api.jar
3> Generating protocol.h
4> javac: file not found:
C:\qpid-proton-0.4\proton-j\proton-api\src\main\java\org\apache\qpi\proton\driver\Connector.java
4> Usage: javac <options> <source files>
4> use -help for a list of possible options
4>C:\Program Files
(x86)\MSBuild\Microsoft.Cpp\v4.0\V110\Microsoft.CppCommon.targets(172,5):
error MSB6006: "cmd.exe" exited with code 2.
I noticed that the directory mentioned on the 3rd line is "qpi" not
"qpid"...
Thanks,
Paul
On Fri, Feb 22, 2013 at 1:55 AM, Cliff Jansen <cl...@gmail.com> wrote:
> Hi Paul,
>
> Thanks for that. I get similar errors building as you do. Note that
> the directory structure changed in 0.4 for the JNI work. Your build
> directory should be under qpid-proton-0.4 (not under proton-c). The
> result is that you picked up the wrong CMakeLists.txt file to start
> from. I opened proton-248 to give you a decent error for this in
> future.
>
> Hopefully, if you build pointing to the correct top level cmake config
> file, you will have a working build.
>
> If you have swig installed, cmake isn't finding it. See the swig
> related comments in the top level README file.
>
> Thank you for the feedback.
>
> Cliff
>
> On Thu, Feb 21, 2013 at 7:18 PM, Paul O'Fallon <pa...@ofallonfamily.com>
> wrote:
> > Sure -- here you go! This is what I get when building 0.4 RC2 on
> Windows 8
> > 64-bit with Visual Studio 2012:
> >
> > https://gist.github.com/pofallon/6666fd31e05971442bc5
> >
> > (This has both the CMAKE output as well as the Visual Studio build
> output)
> >
> > Thanks,
> > Paul
> >
> > On Thu, Feb 21, 2013 at 1:12 PM, Rafael Schloming <rh...@alum.mit.edu>
> wrote:
> >
> >> Please follow up. It should work on at least some versions of windows
> and
> >> if even if we don't hit them all for 0.4 it will be good input for 0.5.
> ;-)
> >>
> >> --Rafael
> >>
> >> On Thu, Feb 21, 2013 at 9:55 AM, Paul O'Fallon <paul@ofallonfamily.com
> >> >wrote:
> >>
> >> > Hello. Should the RC2 build work on Windows w/o any changes? I
> tried it
> >> > on Win8 / VS 2011 and got a warning from cmake and VS errors in the
> build
> >> > process. I wasn't going to bother reporting them until I saw the
> below
> >> > note about win7 and vs2008. If it *should* work on Windows, I'll
> >> follow-up
> >> > with more details about my issues (but didn't want to get in the way
> if
> >> > that's not a part of 0.4).
> >> >
> >> > Thanks,
> >> > Paul
> >> >
> >> > On Wed, Feb 20, 2013 at 4:57 PM, Cliff Jansen <cl...@gmail.com>
> >> > wrote:
> >> >
> >> > > Looks good. Build and ctest success on rhel6 64 bit.
> >> > >
> >> > > Successful build and expected ctest results on Windows 7 and VS2008.
> >> > >
> >> > > Cliff
> >> > >
> >> > > On Wed, Feb 20, 2013 at 3:31 PM, Rafael Schloming <rhs@alum.mit.edu
> >
> >> > > wrote:
> >> > > > Source posted here:
> >> > > > - http://people.apache.org/~rhs/qpid-proton-0.4rc2/
> >> > > >
> >> > > > Java binaries here:
> >> > > > -
> >> > >
> https://repository.apache.org/content/repositories/orgapacheqpid-280/
> >> > > >
> >> > > > I'd like to call an official vote soon, e.g. tomorrow, so please
> >> have a
> >> > > > look and share your results here.
> >> > > >
> >> > > > Changes from RC1:
> >> > > >
> >> > > > PROTON-199: support python 2.4
> >> > > > PROTON-236 freegetopt compat for proton-c windows builds.
> >> > > > PROTON-243: fixed LIB_SUFFIX magic
> >> > > > PROTON-200: maintain a minimum credit level for each receive link
> >> > > > PROTON-200: make similar changes to Java MessengerImpl
> >> > > > PROTON-200: allow recv(-1) to grant unlimited credit
> >> > > > PROTON-232: described arrays seem to force the descriptor to be of
> >> the
> >> > > same
> >> > > > type as the array Fixed bug in code.c pn_data_encode_node: was
> always
> >> > > using
> >> > > > the parent->type for everything inside an array, including the
> >> > > descriptor.
> >> > > > PROTON-242: Shared library used JNI code has poor name
> >> > > "libproton-swig.so"
> >> > > > Shared library now has name libproton-jni.so i.e. follows the
> naming
> >> > > > conventions of its companion jar.
> >> > > > PROTON-217: cmake build system should include install target for
> Java
> >> > > > binaries
> >> > > >
> >> > > > --Rafael
> >> > >
> >> >
> >>
>
Re: 0.4 RC2
Posted by Cliff Jansen <cl...@gmail.com>.
Hi Paul,
Thanks for that. I get similar errors building as you do. Note that
the directory structure changed in 0.4 for the JNI work. Your build
directory should be under qpid-proton-0.4 (not under proton-c). The
result is that you picked up the wrong CMakeLists.txt file to start
from. I opened proton-248 to give you a decent error for this in
future.
Hopefully, if you build pointing to the correct top level cmake config
file, you will have a working build.
If you have swig installed, cmake isn't finding it. See the swig
related comments in the top level README file.
Thank you for the feedback.
Cliff
On Thu, Feb 21, 2013 at 7:18 PM, Paul O'Fallon <pa...@ofallonfamily.com> wrote:
> Sure -- here you go! This is what I get when building 0.4 RC2 on Windows 8
> 64-bit with Visual Studio 2012:
>
> https://gist.github.com/pofallon/6666fd31e05971442bc5
>
> (This has both the CMAKE output as well as the Visual Studio build output)
>
> Thanks,
> Paul
>
> On Thu, Feb 21, 2013 at 1:12 PM, Rafael Schloming <rh...@alum.mit.edu> wrote:
>
>> Please follow up. It should work on at least some versions of windows and
>> if even if we don't hit them all for 0.4 it will be good input for 0.5. ;-)
>>
>> --Rafael
>>
>> On Thu, Feb 21, 2013 at 9:55 AM, Paul O'Fallon <paul@ofallonfamily.com
>> >wrote:
>>
>> > Hello. Should the RC2 build work on Windows w/o any changes? I tried it
>> > on Win8 / VS 2011 and got a warning from cmake and VS errors in the build
>> > process. I wasn't going to bother reporting them until I saw the below
>> > note about win7 and vs2008. If it *should* work on Windows, I'll
>> follow-up
>> > with more details about my issues (but didn't want to get in the way if
>> > that's not a part of 0.4).
>> >
>> > Thanks,
>> > Paul
>> >
>> > On Wed, Feb 20, 2013 at 4:57 PM, Cliff Jansen <cl...@gmail.com>
>> > wrote:
>> >
>> > > Looks good. Build and ctest success on rhel6 64 bit.
>> > >
>> > > Successful build and expected ctest results on Windows 7 and VS2008.
>> > >
>> > > Cliff
>> > >
>> > > On Wed, Feb 20, 2013 at 3:31 PM, Rafael Schloming <rh...@alum.mit.edu>
>> > > wrote:
>> > > > Source posted here:
>> > > > - http://people.apache.org/~rhs/qpid-proton-0.4rc2/
>> > > >
>> > > > Java binaries here:
>> > > > -
>> > > https://repository.apache.org/content/repositories/orgapacheqpid-280/
>> > > >
>> > > > I'd like to call an official vote soon, e.g. tomorrow, so please
>> have a
>> > > > look and share your results here.
>> > > >
>> > > > Changes from RC1:
>> > > >
>> > > > PROTON-199: support python 2.4
>> > > > PROTON-236 freegetopt compat for proton-c windows builds.
>> > > > PROTON-243: fixed LIB_SUFFIX magic
>> > > > PROTON-200: maintain a minimum credit level for each receive link
>> > > > PROTON-200: make similar changes to Java MessengerImpl
>> > > > PROTON-200: allow recv(-1) to grant unlimited credit
>> > > > PROTON-232: described arrays seem to force the descriptor to be of
>> the
>> > > same
>> > > > type as the array Fixed bug in code.c pn_data_encode_node: was always
>> > > using
>> > > > the parent->type for everything inside an array, including the
>> > > descriptor.
>> > > > PROTON-242: Shared library used JNI code has poor name
>> > > "libproton-swig.so"
>> > > > Shared library now has name libproton-jni.so i.e. follows the naming
>> > > > conventions of its companion jar.
>> > > > PROTON-217: cmake build system should include install target for Java
>> > > > binaries
>> > > >
>> > > > --Rafael
>> > >
>> >
>>
Re: 0.4 RC2
Posted by Paul O'Fallon <pa...@ofallonfamily.com>.
Sure -- here you go! This is what I get when building 0.4 RC2 on Windows 8
64-bit with Visual Studio 2012:
https://gist.github.com/pofallon/6666fd31e05971442bc5
(This has both the CMAKE output as well as the Visual Studio build output)
Thanks,
Paul
On Thu, Feb 21, 2013 at 1:12 PM, Rafael Schloming <rh...@alum.mit.edu> wrote:
> Please follow up. It should work on at least some versions of windows and
> if even if we don't hit them all for 0.4 it will be good input for 0.5. ;-)
>
> --Rafael
>
> On Thu, Feb 21, 2013 at 9:55 AM, Paul O'Fallon <paul@ofallonfamily.com
> >wrote:
>
> > Hello. Should the RC2 build work on Windows w/o any changes? I tried it
> > on Win8 / VS 2011 and got a warning from cmake and VS errors in the build
> > process. I wasn't going to bother reporting them until I saw the below
> > note about win7 and vs2008. If it *should* work on Windows, I'll
> follow-up
> > with more details about my issues (but didn't want to get in the way if
> > that's not a part of 0.4).
> >
> > Thanks,
> > Paul
> >
> > On Wed, Feb 20, 2013 at 4:57 PM, Cliff Jansen <cl...@gmail.com>
> > wrote:
> >
> > > Looks good. Build and ctest success on rhel6 64 bit.
> > >
> > > Successful build and expected ctest results on Windows 7 and VS2008.
> > >
> > > Cliff
> > >
> > > On Wed, Feb 20, 2013 at 3:31 PM, Rafael Schloming <rh...@alum.mit.edu>
> > > wrote:
> > > > Source posted here:
> > > > - http://people.apache.org/~rhs/qpid-proton-0.4rc2/
> > > >
> > > > Java binaries here:
> > > > -
> > > https://repository.apache.org/content/repositories/orgapacheqpid-280/
> > > >
> > > > I'd like to call an official vote soon, e.g. tomorrow, so please
> have a
> > > > look and share your results here.
> > > >
> > > > Changes from RC1:
> > > >
> > > > PROTON-199: support python 2.4
> > > > PROTON-236 freegetopt compat for proton-c windows builds.
> > > > PROTON-243: fixed LIB_SUFFIX magic
> > > > PROTON-200: maintain a minimum credit level for each receive link
> > > > PROTON-200: make similar changes to Java MessengerImpl
> > > > PROTON-200: allow recv(-1) to grant unlimited credit
> > > > PROTON-232: described arrays seem to force the descriptor to be of
> the
> > > same
> > > > type as the array Fixed bug in code.c pn_data_encode_node: was always
> > > using
> > > > the parent->type for everything inside an array, including the
> > > descriptor.
> > > > PROTON-242: Shared library used JNI code has poor name
> > > "libproton-swig.so"
> > > > Shared library now has name libproton-jni.so i.e. follows the naming
> > > > conventions of its companion jar.
> > > > PROTON-217: cmake build system should include install target for Java
> > > > binaries
> > > >
> > > > --Rafael
> > >
> >
>
Re: 0.4 RC2
Posted by Rafael Schloming <rh...@alum.mit.edu>.
Please follow up. It should work on at least some versions of windows and
if even if we don't hit them all for 0.4 it will be good input for 0.5. ;-)
--Rafael
On Thu, Feb 21, 2013 at 9:55 AM, Paul O'Fallon <pa...@ofallonfamily.com>wrote:
> Hello. Should the RC2 build work on Windows w/o any changes? I tried it
> on Win8 / VS 2011 and got a warning from cmake and VS errors in the build
> process. I wasn't going to bother reporting them until I saw the below
> note about win7 and vs2008. If it *should* work on Windows, I'll follow-up
> with more details about my issues (but didn't want to get in the way if
> that's not a part of 0.4).
>
> Thanks,
> Paul
>
> On Wed, Feb 20, 2013 at 4:57 PM, Cliff Jansen <cl...@gmail.com>
> wrote:
>
> > Looks good. Build and ctest success on rhel6 64 bit.
> >
> > Successful build and expected ctest results on Windows 7 and VS2008.
> >
> > Cliff
> >
> > On Wed, Feb 20, 2013 at 3:31 PM, Rafael Schloming <rh...@alum.mit.edu>
> > wrote:
> > > Source posted here:
> > > - http://people.apache.org/~rhs/qpid-proton-0.4rc2/
> > >
> > > Java binaries here:
> > > -
> > https://repository.apache.org/content/repositories/orgapacheqpid-280/
> > >
> > > I'd like to call an official vote soon, e.g. tomorrow, so please have a
> > > look and share your results here.
> > >
> > > Changes from RC1:
> > >
> > > PROTON-199: support python 2.4
> > > PROTON-236 freegetopt compat for proton-c windows builds.
> > > PROTON-243: fixed LIB_SUFFIX magic
> > > PROTON-200: maintain a minimum credit level for each receive link
> > > PROTON-200: make similar changes to Java MessengerImpl
> > > PROTON-200: allow recv(-1) to grant unlimited credit
> > > PROTON-232: described arrays seem to force the descriptor to be of the
> > same
> > > type as the array Fixed bug in code.c pn_data_encode_node: was always
> > using
> > > the parent->type for everything inside an array, including the
> > descriptor.
> > > PROTON-242: Shared library used JNI code has poor name
> > "libproton-swig.so"
> > > Shared library now has name libproton-jni.so i.e. follows the naming
> > > conventions of its companion jar.
> > > PROTON-217: cmake build system should include install target for Java
> > > binaries
> > >
> > > --Rafael
> >
>
Re: 0.4 RC2
Posted by Paul O'Fallon <pa...@ofallonfamily.com>.
Hello. Should the RC2 build work on Windows w/o any changes? I tried it
on Win8 / VS 2011 and got a warning from cmake and VS errors in the build
process. I wasn't going to bother reporting them until I saw the below
note about win7 and vs2008. If it *should* work on Windows, I'll follow-up
with more details about my issues (but didn't want to get in the way if
that's not a part of 0.4).
Thanks,
Paul
On Wed, Feb 20, 2013 at 4:57 PM, Cliff Jansen <cl...@gmail.com> wrote:
> Looks good. Build and ctest success on rhel6 64 bit.
>
> Successful build and expected ctest results on Windows 7 and VS2008.
>
> Cliff
>
> On Wed, Feb 20, 2013 at 3:31 PM, Rafael Schloming <rh...@alum.mit.edu>
> wrote:
> > Source posted here:
> > - http://people.apache.org/~rhs/qpid-proton-0.4rc2/
> >
> > Java binaries here:
> > -
> https://repository.apache.org/content/repositories/orgapacheqpid-280/
> >
> > I'd like to call an official vote soon, e.g. tomorrow, so please have a
> > look and share your results here.
> >
> > Changes from RC1:
> >
> > PROTON-199: support python 2.4
> > PROTON-236 freegetopt compat for proton-c windows builds.
> > PROTON-243: fixed LIB_SUFFIX magic
> > PROTON-200: maintain a minimum credit level for each receive link
> > PROTON-200: make similar changes to Java MessengerImpl
> > PROTON-200: allow recv(-1) to grant unlimited credit
> > PROTON-232: described arrays seem to force the descriptor to be of the
> same
> > type as the array Fixed bug in code.c pn_data_encode_node: was always
> using
> > the parent->type for everything inside an array, including the
> descriptor.
> > PROTON-242: Shared library used JNI code has poor name
> "libproton-swig.so"
> > Shared library now has name libproton-jni.so i.e. follows the naming
> > conventions of its companion jar.
> > PROTON-217: cmake build system should include install target for Java
> > binaries
> >
> > --Rafael
>
Re: 0.4 RC2
Posted by Cliff Jansen <cl...@gmail.com>.
Looks good. Build and ctest success on rhel6 64 bit.
Successful build and expected ctest results on Windows 7 and VS2008.
Cliff
On Wed, Feb 20, 2013 at 3:31 PM, Rafael Schloming <rh...@alum.mit.edu> wrote:
> Source posted here:
> - http://people.apache.org/~rhs/qpid-proton-0.4rc2/
>
> Java binaries here:
> - https://repository.apache.org/content/repositories/orgapacheqpid-280/
>
> I'd like to call an official vote soon, e.g. tomorrow, so please have a
> look and share your results here.
>
> Changes from RC1:
>
> PROTON-199: support python 2.4
> PROTON-236 freegetopt compat for proton-c windows builds.
> PROTON-243: fixed LIB_SUFFIX magic
> PROTON-200: maintain a minimum credit level for each receive link
> PROTON-200: make similar changes to Java MessengerImpl
> PROTON-200: allow recv(-1) to grant unlimited credit
> PROTON-232: described arrays seem to force the descriptor to be of the same
> type as the array Fixed bug in code.c pn_data_encode_node: was always using
> the parent->type for everything inside an array, including the descriptor.
> PROTON-242: Shared library used JNI code has poor name "libproton-swig.so"
> Shared library now has name libproton-jni.so i.e. follows the naming
> conventions of its companion jar.
> PROTON-217: cmake build system should include install target for Java
> binaries
>
> --Rafael