You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/11/20 15:40:52 UTC

[GitHub] [commons-bcel] garydgregory commented on pull request #171: Code coverage bcelifier

garydgregory commented on PR #171:
URL: https://github.com/apache/commons-bcel/pull/171#issuecomment-1321163755

   Hello @nbauma109 
   
   Thank you for your PR. There is a lot here but it feels like a mish-mash of different more or less related items.
   
   For example, the PR adds the constructor `org.apache.bcel.generic.PUSH.PUSH(ConstantPoolGen, ArrayType)` but it is neither used nor tested. Either remove it, write a test, or use it and write a test for it. If there are missing APIs, I suggest you cover those in separate PRs. Mixing this new code here makes this PR harder to review.
   
   Based on the title of the PR, I was expecting only tests, it's ok to have other work in here, the different pieces should be clearly documented in the PR description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org