You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/02 01:25:04 UTC

[GitHub] [flink] vchangpengfei opened a new pull request, #20135: Flink 28358

vchangpengfei opened a new pull request, #20135:
URL: https://github.com/apache/flink/pull/20135

   …ValidatorImpl.class conflict problem
   
   
   ## fix class conflict when run in idea
   
   *  when run test `apache.flink.connector.jdbc.table.JdbcLookupTableITCase.testLookup` in local,the jar of calcite-core.jar is loaded before  mudule of flink-table-planner ,lead to  ValidatorImpl.class in calcite-core.jar load priority*
   
   
   ## Brief change log
   
     - *change the dependency order in pom*
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *apache.flink.connector.jdbc.table.JdbcLookupTableITCase.testLookup*.
   
   before
   
   after
   
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: ( no )
     - The runtime per-record code paths (performance sensitive): (no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
     - The S3 file system connector: ( no )
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser closed pull request #20135: [FLINK-28358][connector/jdbc][Tests] fix when debug in local ,the SqlValidatorImpl.class conflict problem

Posted by GitBox <gi...@apache.org>.
MartijnVisser closed pull request #20135: [FLINK-28358][connector/jdbc][Tests] fix when debug in local ,the SqlValidatorImpl.class conflict problem
URL: https://github.com/apache/flink/pull/20135


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #20135: [FLINK-28358][connector/jdbc][Tests] fix when debug in local ,the SqlValidatorImpl.class conflict problem

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20135:
URL: https://github.com/apache/flink/pull/20135#issuecomment-1332706525

   @vchangpengfei We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] vchangpengfei commented on pull request #20135: [FLINK-28358][connector/jdbc][Tests] fix when debug in local ,the SqlValidatorImpl.class conflict problem

Posted by GitBox <gi...@apache.org>.
vchangpengfei commented on PR #20135:
URL: https://github.com/apache/flink/pull/20135#issuecomment-1176141805

   @zentol @MartijnVisser What's your opinion on this pull request?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20135: Flink 28358

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20135:
URL: https://github.com/apache/flink/pull/20135#issuecomment-1172808040

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5b9fff49151f6c98e8ba6365d72e1bf04313c970",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5b9fff49151f6c98e8ba6365d72e1bf04313c970",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5b9fff49151f6c98e8ba6365d72e1bf04313c970 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org