You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by rnewson <gi...@git.apache.org> on 2016/08/25 11:49:55 UTC
[GitHub] couchdb-couch-mrview pull request #54: Reset row_sent at end of query
GitHub user rnewson opened a pull request:
https://github.com/apache/couchdb-couch-mrview/pull/54
Reset row_sent at end of query
We need to reset row_sent to false at the end of the query so that we
will emit '{"rows":{' for the next query (if we're in a multi-query
request).
COUCHDB-3060
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch-mrview 3060-sorted-false-multi-query
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-mrview/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
----
commit 8cab4e0947891ac435c702c4b86198004295a456
Author: Robert Newson <rn...@apache.org>
Date: 2016-08-25T11:47:49Z
Reset row_sent at end of query
We need to reset row_sent to false at the end of the query so that we
will emit '{"rows":{' for the next query (if we're in a multi-query
request).
COUCHDB-3060
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview issue #54: Reset row_sent at end of query
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/54
Did we test this? I think it fails for me:
```
http post http://adm:pass@localhost:15984/d/_design/d1/_view/v1 queries:='[{"key":"1"}, {"sorted":false}]' | jq '.'
{
"results": [
{
"total_rows": 5,
"offset": 1,
"rows": [
{
"id": "1",
"key": "1",
"value": "v"
}
]
},
{
"id": "0",
"key": "0",
"value": "v"
},
{
"id": "4",
"key": "4",
"value": "v"
},
{
"id": "1",
"key": "1",
"value": "v"
},
{
"id": "3",
"key": "3",
"value": "v"
},
{
"id": "2",
"key": "2",
"value": "v"
}
]
}
parse error: Unmatched ']' at line 11, column 1
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview issue #54: Reset row_sent at end of query
Posted by eiri <gi...@git.apache.org>.
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/54
Tested and this is the correct fix +1. But can we wrap that line at 80 chars, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview pull request #54: Reset row_sent at end of query
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch-mrview/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview issue #54: Reset row_sent at end of query
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/54
sure thing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---