You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2018/08/20 05:13:22 UTC
Review Request 68427: Add Tag to Imported Entities for the
AtlasImportRequest that has 'replicatedTo'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68427/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-2818
https://issues.apache.org/jira/browse/ATLAS-2818
Repository: atlas
Description
-------
**Approach**
- New method added to _AtlasEntityStore_ to add classifications without updating entity metadata.
- New class _EntityTagger_ added.
- Modified _AudisWriter.ImportAudit_ to include call to _EntityTagger_.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 467d3839a4aff71b7f3d1e03ccd0a828d2ce8c76
repository/src/main/java/org/apache/atlas/repository/impexp/EntityTagger.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 6a1a88f4fc714ef069b38cdffd2c5fcc653869e1
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 2bfef788d1ff185c635879f329fa62daafec45ce
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 47960f3f760c322d250559fa1cee2e78b8de2d52
repository/src/test/java/org/apache/atlas/repository/impexp/EntityTaggerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/68427/diff/1/
Testing
-------
**Unit tests**
New tests added.
Thanks,
Ashutosh Mestry
Re: Review Request 68427: Add Tag to Imported Entities for the
AtlasImportRequest that has 'replicatedTo'
Posted by Ashutosh Mestry <am...@hortonworks.com>.
> On Aug. 21, 2018, 9:18 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java
> > Lines 50 (patched)
> > <https://reviews.apache.org/r/68427/diff/4/?file=2075697#file2075697line50>
> >
> > Inline with tags we use in demo, use upper-case letters for tag names, like "REPLICATED".
This is a user definied parameter now.
> On Aug. 21, 2018, 9:18 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java
> > Line 169 (original), 176 (patched)
> > <https://reviews.apache.org/r/68427/diff/4/?file=2075697#file2075697line176>
> >
> > ImportAudits doesn't seem to be the right place for 'updateReplicationAttributeForImport()'. Treating it as a transformer (during import) might be a better choice. Please review.
Dropping this for now, I will create a separate JIRA to address this. There is some experimentation I need to do.
> On Aug. 21, 2018, 9:18 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
> > Lines 541 (patched)
> > <https://reviews.apache.org/r/68427/diff/4/?file=2075701#file2075701line541>
> >
> > Instead of try/catch to detect if the entity is already associated with this tag, consider refactoring validateEntityAssociations(), like:
> >
> > if (hasClassification(guid, classification)) {
> > if (!ignoreIfAlreadyPresent) {
> > throw new AtlasBaseException(AtlasErrorCode.INVALID_PARAMETERS, "entity: " + guid + ", is already associated with classification: " + newClassification);
> > }
> > }
This is no longer needed.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68427/#review207695
-----------------------------------------------------------
On Aug. 21, 2018, 4:48 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68427/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 4:48 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2818
> https://issues.apache.org/jira/browse/ATLAS-2818
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
> - New method added to _AtlasEntityStore_ to add classifications without updating entity metadata.
> - New class _EntityTagger_ added.
> - Modified _AudisWriter.ImportAudit_ to include call to _EntityTagger_.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 467d3839a4aff71b7f3d1e03ccd0a828d2ce8c76
> repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 950850e92640fd427d68b8ab1bee5a8f810119cd
> repository/src/main/java/org/apache/atlas/repository/impexp/EntityTagger.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 6a1a88f4fc714ef069b38cdffd2c5fcc653869e1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 2bfef788d1ff185c635879f329fa62daafec45ce
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java 467ced7748e934b4829ee6f7bbafac39020529ac
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 47960f3f760c322d250559fa1cee2e78b8de2d52
> repository/src/test/java/org/apache/atlas/repository/impexp/EntityTaggerTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1BulkImportPercentTest.java 73dfe37c786336ec267247a716a27f53e0d74993
>
>
> Diff: https://reviews.apache.org/r/68427/diff/4/
>
>
> Testing
> -------
>
> **Unit tests**
> New tests added.
>
> **Pre-commit**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/598/
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 68427: Add Tag to Imported Entities for the
AtlasImportRequest that has 'replicatedTo'
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68427/#review207695
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java
Lines 50 (patched)
<https://reviews.apache.org/r/68427/#comment291200>
Inline with tags we use in demo, use upper-case letters for tag names, like "REPLICATED".
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java
Lines 63 (patched)
<https://reviews.apache.org/r/68427/#comment291201>
AuditsWriter doesn't seem to be the right place for 'entityTagger'. Treating it as a transformer (during import) might be a better choice. Please review.
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java
Line 169 (original), 176 (patched)
<https://reviews.apache.org/r/68427/#comment291202>
ImportAudits doesn't seem to be the right place for 'updateReplicationAttributeForImport()'. Treating it as a transformer (during import) might be a better choice. Please review.
repository/src/main/java/org/apache/atlas/repository/impexp/EntityTagger.java
Lines 40 (patched)
<https://reviews.apache.org/r/68427/#comment291204>
Consider marking these as 'final'
repository/src/main/java/org/apache/atlas/repository/impexp/EntityTagger.java
Lines 62 (patched)
<https://reviews.apache.org/r/68427/#comment291203>
Is 'operation' neded here? line #52 passes the classification name for this param. Consider removing it.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
Lines 541 (patched)
<https://reviews.apache.org/r/68427/#comment291207>
Instead of try/catch to detect if the entity is already associated with this tag, consider refactoring validateEntityAssociations(), like:
if (hasClassification(guid, classification)) {
if (!ignoreIfAlreadyPresent) {
throw new AtlasBaseException(AtlasErrorCode.INVALID_PARAMETERS, "entity: " + guid + ", is already associated with classification: " + newClassification);
}
}
- Madhan Neethiraj
On Aug. 21, 2018, 4:48 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68427/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 4:48 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2818
> https://issues.apache.org/jira/browse/ATLAS-2818
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
> - New method added to _AtlasEntityStore_ to add classifications without updating entity metadata.
> - New class _EntityTagger_ added.
> - Modified _AudisWriter.ImportAudit_ to include call to _EntityTagger_.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 467d3839a4aff71b7f3d1e03ccd0a828d2ce8c76
> repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 950850e92640fd427d68b8ab1bee5a8f810119cd
> repository/src/main/java/org/apache/atlas/repository/impexp/EntityTagger.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 6a1a88f4fc714ef069b38cdffd2c5fcc653869e1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 2bfef788d1ff185c635879f329fa62daafec45ce
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java 467ced7748e934b4829ee6f7bbafac39020529ac
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 47960f3f760c322d250559fa1cee2e78b8de2d52
> repository/src/test/java/org/apache/atlas/repository/impexp/EntityTaggerTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1BulkImportPercentTest.java 73dfe37c786336ec267247a716a27f53e0d74993
>
>
> Diff: https://reviews.apache.org/r/68427/diff/4/
>
>
> Testing
> -------
>
> **Unit tests**
> New tests added.
>
> **Pre-commit**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/598/
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 68427: Add Tag to Imported Entities for the
AtlasImportRequest that has 'replicatedTo'
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68427/#review207929
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java
Lines 100 (patched)
<https://reviews.apache.org/r/68427/#comment291579>
Consider changing the log level to "debug".
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java
Line 131 (original), 127 (patched)
<https://reviews.apache.org/r/68427/#comment291580>
Wouldn't it be useful to create targetCluster as well, when targetClusterName is provided? Users can enter other attributes of the target-cluster (like URL, ..) later.
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java
Line 163 (original), 151 (patched)
<https://reviews.apache.org/r/68427/#comment291581>
Wouldn't it be useful to create targetCluster (i.e. this cluster) as well?
- Madhan Neethiraj
On Aug. 24, 2018, 8:13 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68427/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 8:13 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2818
> https://issues.apache.org/jira/browse/ATLAS-2818
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
> - New method added to _AtlasEntityStore_ to add classifications without updating entity metadata.
> - New class _EntityTagger_ added.
> - Modified _AudisWriter.ImportAudit_ to include call to _EntityTagger_.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 467d3839a4aff71b7f3d1e03ccd0a828d2ce8c76
> repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 950850e92640fd427d68b8ab1bee5a8f810119cd
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 8a184fad519c34033cab6f086e669d97b8784c9a
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformer.java dc71c2af4778c2c768ed824132e13e08a272c16f
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformsShaper.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java 467ced7748e934b4829ee6f7bbafac39020529ac
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java 08bbcd2fb9b7648535741f3f54f71eae38767a7e
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsShaperTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsTest.java b241dda6bff42ea65a6ea6f4dd26536d27a62a71
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1BulkImportPercentTest.java 73dfe37c786336ec267247a716a27f53e0d74993
>
>
> Diff: https://reviews.apache.org/r/68427/diff/6/
>
>
> Testing
> -------
>
> **Unit tests**
> New tests added.
>
> **Pre-commit**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/598/
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 68427: Add Tag to Imported Entities for the
AtlasImportRequest that has 'replicatedTo'
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68427/#review207944
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 27, 2018, 2:48 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68427/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2018, 2:48 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2818
> https://issues.apache.org/jira/browse/ATLAS-2818
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
> - New method added to _AtlasEntityStore_ to add classifications without updating entity metadata.
> - New class _EntityTagger_ added.
> - Modified _AudisWriter.ImportAudit_ to include call to _EntityTagger_.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 467d3839a4aff71b7f3d1e03ccd0a828d2ce8c76
> repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 950850e92640fd427d68b8ab1bee5a8f810119cd
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 8a184fad519c34033cab6f086e669d97b8784c9a
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformer.java dc71c2af4778c2c768ed824132e13e08a272c16f
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformsShaper.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java 467ced7748e934b4829ee6f7bbafac39020529ac
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java 08bbcd2fb9b7648535741f3f54f71eae38767a7e
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsShaperTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsTest.java b241dda6bff42ea65a6ea6f4dd26536d27a62a71
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1BulkImportPercentTest.java 73dfe37c786336ec267247a716a27f53e0d74993
>
>
> Diff: https://reviews.apache.org/r/68427/diff/8/
>
>
> Testing
> -------
>
> **Unit tests**
> New tests added.
>
> **Pre-commit**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/618/
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 68427: Add Tag to Imported Entities for the
AtlasImportRequest that has 'replicatedTo'
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68427/
-----------------------------------------------------------
(Updated Aug. 27, 2018, 2:48 a.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
Updates include: Addressed review comments.
Bugs: ATLAS-2818
https://issues.apache.org/jira/browse/ATLAS-2818
Repository: atlas
Description
-------
**Approach**
- New method added to _AtlasEntityStore_ to add classifications without updating entity metadata.
- New class _EntityTagger_ added.
- Modified _AudisWriter.ImportAudit_ to include call to _EntityTagger_.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 467d3839a4aff71b7f3d1e03ccd0a828d2ce8c76
repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 950850e92640fd427d68b8ab1bee5a8f810119cd
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 8a184fad519c34033cab6f086e669d97b8784c9a
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformer.java dc71c2af4778c2c768ed824132e13e08a272c16f
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformsShaper.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java 467ced7748e934b4829ee6f7bbafac39020529ac
repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java 08bbcd2fb9b7648535741f3f54f71eae38767a7e
repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsShaperTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsTest.java b241dda6bff42ea65a6ea6f4dd26536d27a62a71
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1BulkImportPercentTest.java 73dfe37c786336ec267247a716a27f53e0d74993
Diff: https://reviews.apache.org/r/68427/diff/8/
Changes: https://reviews.apache.org/r/68427/diff/7-8/
Testing (updated)
-------
**Unit tests**
New tests added.
**Pre-commit**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/618/
Thanks,
Ashutosh Mestry
Re: Review Request 68427: Add Tag to Imported Entities for the
AtlasImportRequest that has 'replicatedTo'
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68427/#review207942
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformer.java
Lines 168 (patched)
<https://reviews.apache.org/r/68427/#comment291604>
Consider replacing #168 - #180 with the following, to avoid constructing AtlasClassification where possible:
if (entity.getClassifications() != null) {
entity.setClassifications(new ArrayList<AtlasClassification>());
}
for (AtlasClassification c : entity.getClassifications()) {
if (c.getTypeName().equals(classificationName)) { // entity already has this classification; nothing to add
return entity;
}
}
entity.getClassifications().add(new AtlasClassification(classificationName));
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformsShaper.java
Lines 59 (patched)
<https://reviews.apache.org/r/68427/#comment291605>
For better readability, consider replacing lines #59 - #64 with:
if(importTransformer instanceof AddClassification) {
AddClassification addClassification = (AddClassification) importTransformer;
getCreateTag(addClassification.getClassificationName());
}
- Madhan Neethiraj
On Aug. 27, 2018, 12:26 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68427/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2018, 12:26 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2818
> https://issues.apache.org/jira/browse/ATLAS-2818
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
> - New method added to _AtlasEntityStore_ to add classifications without updating entity metadata.
> - New class _EntityTagger_ added.
> - Modified _AudisWriter.ImportAudit_ to include call to _EntityTagger_.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 467d3839a4aff71b7f3d1e03ccd0a828d2ce8c76
> repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 950850e92640fd427d68b8ab1bee5a8f810119cd
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 8a184fad519c34033cab6f086e669d97b8784c9a
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformer.java dc71c2af4778c2c768ed824132e13e08a272c16f
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformsShaper.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java 467ced7748e934b4829ee6f7bbafac39020529ac
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java 08bbcd2fb9b7648535741f3f54f71eae38767a7e
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsShaperTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsTest.java b241dda6bff42ea65a6ea6f4dd26536d27a62a71
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1BulkImportPercentTest.java 73dfe37c786336ec267247a716a27f53e0d74993
>
>
> Diff: https://reviews.apache.org/r/68427/diff/7/
>
>
> Testing
> -------
>
> **Unit tests**
> New tests added.
>
> **Pre-commit**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/610/
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 68427: Add Tag to Imported Entities for the
AtlasImportRequest that has 'replicatedTo'
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68427/
-----------------------------------------------------------
(Updated Aug. 27, 2018, 12:26 a.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
Updates include: Addressed review comments.
Bugs: ATLAS-2818
https://issues.apache.org/jira/browse/ATLAS-2818
Repository: atlas
Description
-------
**Approach**
- New method added to _AtlasEntityStore_ to add classifications without updating entity metadata.
- New class _EntityTagger_ added.
- Modified _AudisWriter.ImportAudit_ to include call to _EntityTagger_.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 467d3839a4aff71b7f3d1e03ccd0a828d2ce8c76
repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 950850e92640fd427d68b8ab1bee5a8f810119cd
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 8a184fad519c34033cab6f086e669d97b8784c9a
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformer.java dc71c2af4778c2c768ed824132e13e08a272c16f
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformsShaper.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java 467ced7748e934b4829ee6f7bbafac39020529ac
repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java 08bbcd2fb9b7648535741f3f54f71eae38767a7e
repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsShaperTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsTest.java b241dda6bff42ea65a6ea6f4dd26536d27a62a71
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1BulkImportPercentTest.java 73dfe37c786336ec267247a716a27f53e0d74993
Diff: https://reviews.apache.org/r/68427/diff/7/
Changes: https://reviews.apache.org/r/68427/diff/6-7/
Testing (updated)
-------
**Unit tests**
New tests added.
**Pre-commit**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/610/
Thanks,
Ashutosh Mestry
Re: Review Request 68427: Add Tag to Imported Entities for the
AtlasImportRequest that has 'replicatedTo'
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68427/
-----------------------------------------------------------
(Updated Aug. 24, 2018, 8:13 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
Updates include: Addressed review comments.
Bugs: ATLAS-2818
https://issues.apache.org/jira/browse/ATLAS-2818
Repository: atlas
Description
-------
**Approach**
- New method added to _AtlasEntityStore_ to add classifications without updating entity metadata.
- New class _EntityTagger_ added.
- Modified _AudisWriter.ImportAudit_ to include call to _EntityTagger_.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java f56fe227443cde9951e00e67078d91d294fa1df9
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 467d3839a4aff71b7f3d1e03ccd0a828d2ce8c76
repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 950850e92640fd427d68b8ab1bee5a8f810119cd
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 8a184fad519c34033cab6f086e669d97b8784c9a
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformer.java dc71c2af4778c2c768ed824132e13e08a272c16f
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformsShaper.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 6a1a88f4fc714ef069b38cdffd2c5fcc653869e1
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 2bfef788d1ff185c635879f329fa62daafec45ce
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java 467ced7748e934b4829ee6f7bbafac39020529ac
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 47960f3f760c322d250559fa1cee2e78b8de2d52
repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java 08bbcd2fb9b7648535741f3f54f71eae38767a7e
repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsShaperTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsTest.java b241dda6bff42ea65a6ea6f4dd26536d27a62a71
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1BulkImportPercentTest.java 73dfe37c786336ec267247a716a27f53e0d74993
Diff: https://reviews.apache.org/r/68427/diff/5/
Changes: https://reviews.apache.org/r/68427/diff/4-5/
Testing
-------
**Unit tests**
New tests added.
**Pre-commit**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/598/
Thanks,
Ashutosh Mestry
Re: Review Request 68427: Add Tag to Imported Entities for the
AtlasImportRequest that has 'replicatedTo'
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68427/
-----------------------------------------------------------
(Updated Aug. 21, 2018, 4:48 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
Updates include:
- Published.
Bugs: ATLAS-2818
https://issues.apache.org/jira/browse/ATLAS-2818
Repository: atlas
Description
-------
**Approach**
- New method added to _AtlasEntityStore_ to add classifications without updating entity metadata.
- New class _EntityTagger_ added.
- Modified _AudisWriter.ImportAudit_ to include call to _EntityTagger_.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 467d3839a4aff71b7f3d1e03ccd0a828d2ce8c76
repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 950850e92640fd427d68b8ab1bee5a8f810119cd
repository/src/main/java/org/apache/atlas/repository/impexp/EntityTagger.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 6a1a88f4fc714ef069b38cdffd2c5fcc653869e1
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 2bfef788d1ff185c635879f329fa62daafec45ce
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java 467ced7748e934b4829ee6f7bbafac39020529ac
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 47960f3f760c322d250559fa1cee2e78b8de2d52
repository/src/test/java/org/apache/atlas/repository/impexp/EntityTaggerTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1BulkImportPercentTest.java 73dfe37c786336ec267247a716a27f53e0d74993
Diff: https://reviews.apache.org/r/68427/diff/4/
Changes: https://reviews.apache.org/r/68427/diff/3-4/
Testing
-------
**Unit tests**
New tests added.
**Pre-commit**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/598/
Thanks,
Ashutosh Mestry
Re: Review Request 68427: Add Tag to Imported Entities for the
AtlasImportRequest that has 'replicatedTo'
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68427/
-----------------------------------------------------------
(Updated Aug. 20, 2018, 5:59 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
Changes
-------
Updates include: Pre-commit build details.
Bugs: ATLAS-2818
https://issues.apache.org/jira/browse/ATLAS-2818
Repository: atlas
Description
-------
**Approach**
- New method added to _AtlasEntityStore_ to add classifications without updating entity metadata.
- New class _EntityTagger_ added.
- Modified _AudisWriter.ImportAudit_ to include call to _EntityTagger_.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 467d3839a4aff71b7f3d1e03ccd0a828d2ce8c76
repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 950850e92640fd427d68b8ab1bee5a8f810119cd
repository/src/main/java/org/apache/atlas/repository/impexp/EntityTagger.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 6a1a88f4fc714ef069b38cdffd2c5fcc653869e1
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 2bfef788d1ff185c635879f329fa62daafec45ce
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java 467ced7748e934b4829ee6f7bbafac39020529ac
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 47960f3f760c322d250559fa1cee2e78b8de2d52
repository/src/test/java/org/apache/atlas/repository/impexp/EntityTaggerTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1BulkImportPercentTest.java 73dfe37c786336ec267247a716a27f53e0d74993
Diff: https://reviews.apache.org/r/68427/diff/3/
Testing (updated)
-------
**Unit tests**
New tests added.
**Pre-commit**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/598/
Thanks,
Ashutosh Mestry