You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/07/25 23:06:59 UTC

Review Request 68048: Added documentation for per-framework metrics.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68048/
-----------------------------------------------------------

Review request for mesos and Gastón Kleiman.


Repository: mesos


Description
-------

Added documentation for per-framework metrics.


Diffs
-----

  docs/monitoring.md 336f3aa7d2440e826765ae2bf022a5f6acac2927 


Diff: https://reviews.apache.org/r/68048/diff/1/


Testing
-------


Thanks,

Greg Mann


Re: Review Request 68048: Added documentation for per-framework metrics.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68048/#review206486
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67962', '66820', '67776', '67809', '67812', '67813', '67814', '66843', '66855', '66856', '66870', '67878', '67187', '67823', '68048']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1982/mesos-review-68048

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1982/mesos-review-68048/logs/mesos-tests-stdout.log):

```
[----------] 9 tests from Endpoint/SlaveEndpointTest (861 ms total)

[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (27 ms)
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (32 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (61 ms total)

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (623 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (645 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (683 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (705 ms total)

[----------] Global test environment tear-down
[==========] 1012 tests from 98 test cases ran. (497444 ms total)
[  PASSED  ] 1010 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] ContentType/SchedulerTest.Suppress/0, where GetParam() = application/x-protobuf
[  FAILED  ] ContentType/SchedulerTest.Suppress/1, where GetParam() = application/json

 2 FAILED TESTS
  YOU HAVE 222 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1982/mesos-review-68048/logs/mesos-tests-stderr.log):

```
I0726 00:03:26.860007 16292 slave.cpp:3939] Shutting down framework 6551e320-4891-415f-8d36-a462e19dba64-0000
I0726 00:03:26.860007 15356 master.cpp:10963] Updating the state of task 4bccf2bc-dc23-4dce-af7f-ed3bb6da426b of framework 6551e320-4891-415f-8d36-a462e19dba64-0000 (latest state: TASK_KILLED, status I0726 00:03:26.713029  4684 exec.cpp:162] Version: 1.7.0
I0726 00:03:26.735002 13852 exec.cpp:236] Executor registered on agent 6551e320-4891-415f-8d36-a462e19dba64-S0
I0726 00:03:26.739004 13224 executor.cpp:182] Received SUBSCRIBED event
I0726 00:03:26.743039 13224 executor.cpp:186] Subscribed executor on windows-04.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0726 00:03:26.744038 13224 executor.cpp:182] Received LAUNCH event
I0726 00:03:26.748013 13224 executor.cpp:679] Starting task 4bccf2bc-dc23-4dce-af7f-ed3bb6da426b
I0726 00:03:26.823034 13224 executor.cpp:499] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0726 00:03:26.831207 13224 executor.cpp:693] Forked command at 9072
I0726 00:03:26.862200 13448 exec.cpp:445] Executor asked to shutdown
I0726 00:03:26.862989 13224 executor.cpp:182] Received SHUTDOWN event
I0726 00:03:26.862989 13224 executor.cpp:796] Shutting down
I0726 00:03:26.862989 13224 executor.cpp:909] Sending SIGTERM to process tree at pid 907update state: TASK_KILLED)
I0726 00:03:26.860007 16292 slave.cpp:6658] Shutting down executor '4bccf2bc-dc23-4dce-af7f-ed3bb6da426b' of framework 6551e320-4891-415f-8d36-a462e19dba64-0000 at executor(1)@192.10.1.10:64824
I0726 00:03:26.862200 16292 slave.cpp:931] Agent terminating
W0726 00:03:26.862989 16292 slave.cpp:3935] Ignoring shutdown framework 6551e320-4891-415f-8d36-a462e19dba64-0000 because it is terminating
I0726 00:03:26.862989 15356 master.cpp:11061] Removing task 4bccf2bc-dc23-4dce-af7f-ed3bb6da426b with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 6551e320-4891-415f-8d36-a462e19dba64-0000 on agent 6551e320-4891-415f-8d36-a462e19dba64-S0 at slave(462)@192.10.1.10:63114 (windows-04.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0726 00:03:26.865985 15356 master.cpp:1338] Agent 6551e320-4891-415f-8d36-a462e19dba64-S0 at slave(462)@192.10.1.10:63114 (windows-04.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0726 00:03:26.866997 15356 master.cpp:3354] Disconnecting agent 6551e320-4891-415f-8d36-a462e19dba64-S0 at slave(462)@192.10.1.10:63114 (windows-04.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0726 00:03:26.866997 15356 master.cpp:3373] Deactivating agent 6551e320-4891-415f-8d36-a462e19dba64-S0 at slave(462)@192.10.1.10:63114 (windows-04.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0726 00:03:26.866997 13532 hierarchical.cpp:358] Removed framework 6551e320-4891-415f-8d36-a462e19dba64-0000
I0726 00:03:26.866997 15576 containerizer.cpp:2407] Destroying container e10397f7-9681-4a45-aa06-dfb64eb4e2ba in RUNNING state
I0726 00:03:26.868005 15576 containerizer.cpp:3021] Transitioning the state of container e10397f7-9681-4a45-aa06-dfb64eb4e2ba from RUNNING to DESTROYING
I0726 00:03:26.868005 13532 hierarchical.cpp:794] Agent 6551e320-4891-415f-8d36-a462e19dba64-S0 deactivated
I0726 00:03:26.868005 15576 launcher.cpp:155] Asked to destroy container e10397f7-9681-4a45-aa06-dfb64eb4e2ba
I0726 00:03:26.962311 10708 containerizer.cpp:2860] Container e10397f7-9681-4a45-aa06-dfb64eb4e2ba has exited
I0726 00:03:26.992296 13292 master.cpp:1180] Master terminating
I0726 00:03:26.994299 15828 hierarchical.cpp:636] Removed agent 6551e320-4891-415f-8d36-a462e19dba64-S0
I0726 00:03:27.377292   136 process.cpp:926] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On July 25, 2018, 11:06 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68048/
> -----------------------------------------------------------
> 
> (Updated July 25, 2018, 11:06 p.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for per-framework metrics.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 336f3aa7d2440e826765ae2bf022a5f6acac2927 
> 
> 
> Diff: https://reviews.apache.org/r/68048/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 68048: Added documentation for per-framework metrics.

Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68048/#review206613
-----------------------------------------------------------


Ship it!




Ship It!

- Gastón Kleiman


On July 25, 2018, 4:06 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68048/
> -----------------------------------------------------------
> 
> (Updated July 25, 2018, 4:06 p.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for per-framework metrics.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 336f3aa7d2440e826765ae2bf022a5f6acac2927 
> 
> 
> Diff: https://reviews.apache.org/r/68048/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 68048: Added documentation for per-framework metrics.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68048/#review206534
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67962, 66820, 67776, 67809, 67812, 67813, 67814, 66843, 66855, 66856, 66870, 67878, 67187, 67823, 68048]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 25, 2018, 4:06 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68048/
> -----------------------------------------------------------
> 
> (Updated July 25, 2018, 4:06 p.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for per-framework metrics.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 336f3aa7d2440e826765ae2bf022a5f6acac2927 
> 
> 
> Diff: https://reviews.apache.org/r/68048/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>