You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/17 09:03:52 UTC
[PR] consolidate: stable audit queries and applied-filter export [rocketmq-dashboard]
Aias00 opened a new pull request, #2314:
URL: https://github.com/apache/rocketmq-dashboard/pull/2314
## Consolidates
- #1960 applied audit-filter export
- #2270 stable persisted audit queries
This combines the audit query repository stability work with its export UI flow.
## Validation
- `git diff --check` passed.
- No unresolved merge markers.
- Java 21 targeted Maven test passed: `MybatisPlusAuditRepositoryTest` (3 tests).
## Review carry-over
#1960 has outstanding requested changes; this Draft preserves them for resolution during review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(audit): stabilize queries and preserve applied filters in exports [rocketmq-dashboard]
Posted by "tju-yxq (via GitHub)" <gi...@apache.org>.
tju-yxq commented on PR #2314:
URL: https://github.com/apache/rocketmq-dashboard/pull/2314#issuecomment-5351319124
@lizhimins The requested assertion update is present in the latest head 2ec033c: MybatisPlusAuditRepositoryTest now asserts gmt_create and id, matching the current page ordering. The branch is no longer draft, is MERGEABLE/CLEAN against the current trunk, and its three CI checks are successful. The only outstanding review state appears to be the earlier CHANGES_REQUESTED, which referenced the old head 17accab2 before that assertion fix. Could you re-review when convenient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(audit): stabilize queries and preserve applied filters in exports [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #2314:
URL: https://github.com/apache/rocketmq-dashboard/pull/2314#issuecomment-5479892184
Rebased onto the latest rocketmq-studio and resolved the AuditPage.test.tsx conflict by dropping the stale frontend export-timing test, since the current base already includes the debounced export/search sequencing behavior. The remaining diff is scoped to backend audit query stability and filter option caching: stable gmt_create/id ordering, 30s filter option cache, and cache invalidation on writes.\n\nVerification:\n- JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q -Dtest=org.apache.rocketmq.studio.ops.audit.MybatisPlusAuditRepositoryTest,org.apache.rocketmq.studio.ops.audit.AuditServiceTest,org.apache.rocketmq.studio.ops.audit.AuditControllerTest test\n- JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q -DskipTests compile\n- git diff --check origin/rocketmq-studio...HEAD\n\nAll rewritten commits include Signed-off-by. @lizhimins could you please take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] consolidate: stable audit queries and applied-filter export [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #2314:
URL: https://github.com/apache/rocketmq-dashboard/pull/2314#issuecomment-5316513849
Rebased onto current `rocketmq-studio` (`5156a8a5`) and updated audit ordering to the new `gmt_create DESC, id DESC` schema contract. CI has been re-triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] consolidate: stable audit queries and applied-filter export [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #2314:
URL: https://github.com/apache/rocketmq-dashboard/pull/2314#issuecomment-5327675249
Updated the repository SQL assertion to use `gmt_create`, matching the current schema ordering. Verified with `JAVA_HOME=$(/usr/libexec/java_home -v 21) mvn -Dtest=MybatisPlusAuditRepositoryTest test` (3 tests passed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] consolidate: stable audit queries and applied-filter export [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #2314:
URL: https://github.com/apache/rocketmq-dashboard/pull/2314#issuecomment-5316197938
⚠️ **Merge conflict detected**
This PR has conflicts with the base branch and cannot be merged. Please rebase or merge the base branch into your branch and resolve the conflicts:
```bash
git fetch origin
git checkout consolidate/studio-audit-management
git rebase origin/master
# resolve conflicts, then:
git push --force-with-lease
```
This is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved.
---
*Automated notification by github-manager-bot*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(audit): stabilize persisted audit queries [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #2314:
URL: https://github.com/apache/rocketmq-dashboard/pull/2314#issuecomment-5502805821
Superseded by #2966, which consolidates this change with the related Studio fixes on the current `rocketmq-studio` baseline. The replacement PR is Ready and currently CLEAN/MERGEABLE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(audit): stabilize persisted audit queries [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #2314: fix(audit): stabilize persisted audit queries
URL: https://github.com/apache/rocketmq-dashboard/pull/2314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(audit): stabilize queries and preserve applied filters in exports [rocketmq-dashboard]
Posted by "tju-yxq (via GitHub)" <gi...@apache.org>.
tju-yxq commented on PR #2314:
URL: https://github.com/apache/rocketmq-dashboard/pull/2314#issuecomment-5351391337
@lizhimins The requested operated_at → gmt_create assertion update is present in the latest head 2ec033c; the branch is MERGEABLE/CLEAN against the current trunk and all three CI checks are successful. The earlier CHANGES_REQUESTED review points to the pre-fix commit 17accab2. Could you re-review the latest head when convenient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org