You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Leif Hedstrom (JIRA)" <ji...@apache.org> on 2016/06/27 21:56:57 UTC

[jira] [Updated] (TS-4598) Coverity Null-Check after deref in NetworkUtilisRemote.cc

     [ https://issues.apache.org/jira/browse/TS-4598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom updated TS-4598:
------------------------------
    Description: 
{code}
** 1237320 Dereference before null check **
___________________________________________
660  event_notice = (TSMgmtEvent *)arg;
   	deref_ptr: Directly dereferencing pointer event_notice.
661  index        = (int)event_notice->id;
662  LLQ *func_q; // list of callback functions need to call
663
664  func_q = create_queue();
665  if (!func_q) {
   	
CID 1237320 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking event_notice suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
666    if (event_notice)
667      TSEventDestroy(event_notice);
668    return NULL;
669  }
 ___________________________________________
{code}

  was:
** 1237320 Dereference before null check **
___________________________________________
660  event_notice = (TSMgmtEvent *)arg;
   	deref_ptr: Directly dereferencing pointer event_notice.
661  index        = (int)event_notice->id;
662  LLQ *func_q; // list of callback functions need to call
663
664  func_q = create_queue();
665  if (!func_q) {
   	
CID 1237320 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking event_notice suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
666    if (event_notice)
667      TSEventDestroy(event_notice);
668    return NULL;
669  }
 ___________________________________________



> Coverity Null-Check after deref in NetworkUtilisRemote.cc
> ---------------------------------------------------------
>
>                 Key: TS-4598
>                 URL: https://issues.apache.org/jira/browse/TS-4598
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Tyler Stroh
>            Assignee: Tyler Stroh
>             Fix For: 7.0.0
>
>
> {code}
> ** 1237320 Dereference before null check **
> ___________________________________________
> 660  event_notice = (TSMgmtEvent *)arg;
>    	deref_ptr: Directly dereferencing pointer event_notice.
> 661  index        = (int)event_notice->id;
> 662  LLQ *func_q; // list of callback functions need to call
> 663
> 664  func_q = create_queue();
> 665  if (!func_q) {
>    	
> CID 1237320 (#1 of 1): Dereference before null check (REVERSE_INULL)
> check_after_deref: Null-checking event_notice suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
> 666    if (event_notice)
> 667      TSEventDestroy(event_notice);
> 668    return NULL;
> 669  }
>  ___________________________________________
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)