You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/03 16:19:04 UTC
[jira] [Commented] (THRIFT-4625) let / const variable decorators
for es6 compiler
[ https://issues.apache.org/jira/browse/THRIFT-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602309#comment-16602309 ]
ASF GitHub Bot commented on THRIFT-4625:
----------------------------------------
bforbis commented on issue #1584: THRIFT-4625: Use let/const variable decorators in ES6 Javascript
URL: https://github.com/apache/thrift/pull/1584#issuecomment-418155339
It seems like I ran into an issue where I pulled on a thread and unravelled the entire rug. This requires a decently large overhaul of the test system for javascript, which is currently relying on a very old version of QUnit which relies on a now defunct version of PhantomJS.
QUnit has since moved to using puppeteer on top of headless chrome, which has full ES6 support. The advantage of this is we don't need any transpilation / polyfills, but getting the build dependencies installed across all the docker images is a bit tricky.
I think I've gotten it resolved for ubuntu-bionic, but ubuntu-xenial is showing some issues (I think due to it having an older version of nodejs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> let / const variable decorators for es6 compiler
> ------------------------------------------------
>
> Key: THRIFT-4625
> URL: https://issues.apache.org/jira/browse/THRIFT-4625
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Compiler, Node.js - Compiler
> Reporter: Brian Forbis
> Priority: Minor
>
> With support for the ES6 compiler, variables should be scoped using the ES6 *let* and *const* variable decorators to define variable scoping and read/write behavior.
> This brings the generated code into compliance with the [no-var|https://eslint.org/docs/rules/no-var] eslint rule.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)