You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/08 10:38:23 UTC

[GitHub] [rocketmq] ferrirW commented on pull request #3435: [ISSUE #3424] Validators.checkMessage() is used twice.

ferrirW commented on pull request #3435:
URL: https://github.com/apache/rocketmq/pull/3435#issuecomment-1061637389


   ![image](https://user-images.githubusercontent.com/42178996/157219185-70b622c4-e9d9-471d-9eaa-6404669990f2.png)
   
   This check is used to avoid NPE?
   
   I think better way to check and set topic with namespace is that move all checkMessage & msg.setTopic to defaultMQProducerImpl.send().
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org