[jira] [Commented] (MJAVADOC-485) Upgrade to commons-lang3

["Peter Ansell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MJAVADOC-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075781#comment-16075781 ] 

Peter Ansell commented on MJAVADOC-485:
---------------------------------------

I can't reproduce the MJAVADOC-488 issue using the 3.0.0-SNAPSHOT in trunk (but I can replicate it using 2.10.4, which is why I am here). This is despite the commons-lang:2.6 version still being present in the pom.xml file, so it may not be a complete duplicate of this issue, as the "9" versus "9-ea" runtime failure seems to be fixed already. 

There is still a warning about illegal reflective access by commons-lang, which was downgraded by default from failure in previous 9-ea releases to just a warning in 9b175 to give people time to fix their code:

{noformat}
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.apache.commons.lang.builder.EqualsBuilder (file:/home/mint/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar) to field java.util.ArrayList.serialVersionUID
WARNING: Please consider reporting this to the maintainers of org.apache.commons.lang.builder.EqualsBuilder
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
{noformat}

There are still test failures when building the trunk maven-javadoc-plugin with JDK-9. However, running javadoc:javadoc on a Java-9 built project after using JDK-9b175 to build maven-javadoc-plugin with "-DskipTests" seems to be still creating useful javadoc HTML pages so the test failures aren't signals that it is completely broken:

{noformat}

Results :

Failed tests: 
  org.apache.maven.plugin.javadoc.JavadocReportTest#testDocfiles AssertionFailedError
  org.apache.maven.plugin.javadoc.JavadocReportTest#testJavadocResources AssertionFailedError
  org.apache.maven.plugin.javadoc.JavadocReportTest#testTagletArtifacts AssertionFailedError
Tests in error: 
  org.apache.maven.plugin.javadoc.FixJavadocMojoTest#testFix MavenInvocationException
  org.apache.maven.plugin.javadoc.FixJavadocMojoTest#testFixJdk5 MavenInvocationException
  org.apache.maven.plugin.javadoc.FixJavadocMojoTest#testFixJdk6 MavenInvocationException
  org.apache.maven.plugin.javadoc.JavadocReportTest#testJdk5 MojoExecutionException

Tests run: 59, Failures: 3, Errors: 4, Skipped: 0
{noformat}

> Upgrade to commons-lang3
> ------------------------
>
>                 Key: MJAVADOC-485
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-485
>             Project: Maven Javadoc Plugin
>          Issue Type: Dependency upgrade
>    Affects Versions: 2.10.4
>            Reporter: Philippe Marschall
>
> The plugin is currently on commons-lang 2.6, the most recent version is 3.6.
> [The upgrade |https://commons.apache.org/proper/commons-lang/article3_0.html] is fairly trivial expect one point, {{SystemUtils.JAVA_VERSION_FLOAT}} is no longer available. For some parts there are easy fixes but for {{AbstractJavadocMojo}} the simplest fix seemed to use {{JavadocUtil#parseJavadocVersion(String)}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)