You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Christoffer Sawicki (JIRA)" <ji...@apache.org> on 2013/04/03 13:17:15 UTC
[jira] [Created] (AMQ-4433) Socket parameters are not validated
Christoffer Sawicki created AMQ-4433:
----------------------------------------
Summary: Socket parameters are not validated
Key: AMQ-4433
URL: https://issues.apache.org/jira/browse/AMQ-4433
Project: ActiveMQ
Issue Type: Bug
Reporter: Christoffer Sawicki
Priority: Minor
Connect parameters are validated in every transport factory with a statement like this:
{noformat}
if (!options.isEmpty()) {
throw new IllegalArgumentException("Invalid connect parameters: " + options);
}
{noformat}
Socket parameters (i.e. connect parameters prefixed with {{socket.}}) are however never validated.
They are put away at
{noformat}
SslTransportFactory(TcpTransportFactory).compositeConfigure(Transport, WireFormat, Map) line: 85
{noformat}
and then set at
{noformat}
SslTransport(TcpTransport).initialiseSocket(Socket) line: 428
{noformat}
where there is no check that {{socketOptions}} is empty after the call.
I've attached a patch that rectifies this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira