You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "vyasdevanshu (via GitHub)" <gi...@apache.org> on 2026/05/15 09:31:20 UTC

Re: [PR] Fixed: sendInvoicePerEmail fails with MissingMethodException (OFBIZ-13388) [ofbiz-framework]

vyasdevanshu commented on code in PR #1131:
URL: https://github.com/apache/ofbiz-framework/pull/1131#discussion_r3247224302


##########
applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/invoice/InvoiceServicesScript.groovy:
##########
@@ -564,7 +563,7 @@ Map addTaxOnInvoice() {
         addTaxMap.itemAmountList << totalAmount
         addTaxMap.itemPriceList << it.amount
         addTaxMap.itemQuantityList << it.quantity
-        addTaxMap.itemShippingList << BigDecimal.ZERO
+        addTaxMap.itemShippingList << 0

Review Comment:
   This change is out of context of the ticket fix. 
   Is there any specific reason to include this in the current changes?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org