You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@newton.ch.collab.net> on 2002/05/29 17:04:03 UTC
question for hadaka
Hadaka -- thanks for spotting the dereferencing problem in
svn_repos_get_committed_info(), fixed now.
I also took a look at set_any_props(), as you mentioned, but didn't
see any bug there. Did see some unnecessary code, including a
pointless apr_pstrdup(), which I removed, but no correctness problem.
Was there something specific you had in mind?
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
[PATCH] Re: question for hadaka
Posted by Nuutti Kotivuori <na...@iki.fi>.
Karl Fogel wrote:
> Hadaka -- thanks for spotting the dereferencing problem in
> svn_repos_get_committed_info(), fixed now.
>
> I also took a look at set_any_props(), as you mentioned, but didn't
> see any bug there. Did see some unnecessary code, including a
> pointless apr_pstrdup(), which I removed, but no correctness
> problem. Was there something specific you had in mind?
Yes.
-- Naked
Index: ./subversion/libsvn_ra_local/checkout.c
===================================================================
--- ./subversion/libsvn_ra_local/checkout.c
+++ ./subversion/libsvn_ra_local/checkout.c Wed May 29 22:04:58 2002
@@ -91,11 +91,13 @@
apr_hash_set (props, SVN_PROP_ENTRY_COMMITTED_DATE,
strlen(SVN_PROP_ENTRY_COMMITTED_DATE),
- svn_string_create (committed_date, pool));
+ committed_date ?
+ svn_string_create (committed_date, pool) : NULL);
apr_hash_set (props, SVN_PROP_ENTRY_LAST_AUTHOR,
strlen(SVN_PROP_ENTRY_LAST_AUTHOR),
- svn_string_create (last_author, pool));
+ last_author ?
+ svn_string_create (last_author, pool) : NULL);
/* Loop over properties, send them through the editor. */
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org