You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yongjiaw <gi...@git.apache.org> on 2015/10/27 17:55:36 UTC
[GitHub] spark pull request: [SPARK-11354] [Web UI] expose custom log4j to ...
GitHub user yongjiaw opened a pull request:
https://github.com/apache/spark/pull/9307
[SPARK-11354] [Web UI] expose custom log4j to executor page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yongjiaw/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9307.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9307
----
commit b25723af88412520aecab1aebaf12cb63c4d696c
Author: EC2 Default User <ec...@ip-172-31-51-63.ec2.internal>
Date: 2015-10-27T16:49:40Z
expose custom log4j to executor page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11354] [Web UI] expose custom log4j to ...
Posted by yongjiaw <gi...@git.apache.org>.
Github user yongjiaw commented on the pull request:
https://github.com/apache/spark/pull/9307#issuecomment-151582982
@JoshRosen, I started this as a hack. The only thing I don't feel good about it is I have to remove the logType checks from LogPage.scala, which runs with the worker process and is not aware of the executor's loggers. It works for the driver's executorPage because the driver is already listening for executor data. Similarly, the worker page right now only has hard-coded links to stdout and stderr. Maybe this can be further improved by letting worker listen to executors. This small step should be useful enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11354] [Web UI] expose custom log4j to ...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9307#issuecomment-151576940
Hey @yongjiaw, thanks for submitting this! I've been wanting to do something like this myself, so I plan to take a look at this PR and will try it out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11354] [Web UI] expose custom log4j to ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9307#issuecomment-151568378
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11354] [Web UI] expose custom log4j to ...
Posted by yongjiaw <gi...@git.apache.org>.
Github user yongjiaw closed the pull request at:
https://github.com/apache/spark/pull/9307
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11354] [Web UI] expose custom log4j to ...
Posted by yongjiaw <gi...@git.apache.org>.
Github user yongjiaw commented on the pull request:
https://github.com/apache/spark/pull/9307#issuecomment-151734456
this PR had some issue, I created another one. Closing this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11354] [Web UI] expose custom log4j to ...
Posted by yongjiaw <gi...@git.apache.org>.
Github user yongjiaw commented on the pull request:
https://github.com/apache/spark/pull/9307#issuecomment-151734523
https://github.com/apache/spark/pull/9321
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org