You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2018/09/27 12:20:01 UTC
[arrow] 22/24: PARQUET-1256: Add --print-key-value-metadata option
to parquet_reader tool
This is an automated email from the ASF dual-hosted git repository.
wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
commit 37207bdb509edd5ddd5edb33f9714c2c10497d10
Author: Jacek Pliszka <Ja...@gmail.com>
AuthorDate: Fri Aug 17 17:52:29 2018 -0400
PARQUET-1256: Add --print-key-value-metadata option to parquet_reader tool
This is a minor change useful for debugging.
Now parquet_reader tool has --print-key-value-metadata which when present, dump of key values of file metadata is done.
Created https://issues.apache.org/jira/browse/PARQUET-1256
Author: Jacek Pliszka <Ja...@gmail.com>
Closes #450 from JacekPliszka/master and squashes the following commits:
0d9a108 [Jacek Pliszka] Added --print-key-value-metadata option to parquet_reader tool
Change-Id: Ie6ad3037bcfe59128ad39d2408c8a2656666fbc1
---
cpp/tools/parquet/parquet_reader.cc | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/cpp/tools/parquet/parquet_reader.cc b/cpp/tools/parquet/parquet_reader.cc
index 7ef59dc..34bdfc1 100644
--- a/cpp/tools/parquet/parquet_reader.cc
+++ b/cpp/tools/parquet/parquet_reader.cc
@@ -24,13 +24,14 @@
int main(int argc, char** argv) {
if (argc > 5 || argc < 2) {
std::cerr << "Usage: parquet_reader [--only-metadata] [--no-memory-map] [--json]"
- "[--columns=...] <file>"
+ "[--print-key-value-metadata] [--columns=...] <file>"
<< std::endl;
return -1;
}
std::string filename;
bool print_values = true;
+ bool print_key_value_metadata = false;
bool memory_map = true;
bool format_json = false;
@@ -42,6 +43,8 @@ int main(int argc, char** argv) {
for (int i = 1; i < argc; i++) {
if ((param = std::strstr(argv[i], "--only-metadata"))) {
print_values = false;
+ } else if ((param = std::strstr(argv[i], "--print-key-value-metadata"))) {
+ print_key_value_metadata = true;
} else if ((param = std::strstr(argv[i], "--no-memory-map"))) {
memory_map = false;
} else if ((param = std::strstr(argv[i], "--json"))) {
@@ -64,7 +67,8 @@ int main(int argc, char** argv) {
if (format_json) {
printer.JSONPrint(std::cout, columns, filename.c_str());
} else {
- printer.DebugPrint(std::cout, columns, print_values, filename.c_str());
+ printer.DebugPrint(std::cout, columns, print_values,
+ print_key_value_metadata, filename.c_str());
}
} catch (const std::exception& e) {
std::cerr << "Parquet error: " << e.what() << std::endl;