You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/01 19:40:20 UTC
[GitHub] [airflow] kosteev opened a new pull request #17450: Add missing menu access for dag dependencies and configurations pages
kosteev opened a new pull request #17450:
URL: https://github.com/apache/airflow/pull/17450
closes: #17449
Add missing menu access for following pages for "Op" role:
- "Browse" -> "DAG Dependencies"
- "Admin" -> "Configurations"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kosteev commented on pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
kosteev commented on pull request #17450:
URL: https://github.com/apache/airflow/pull/17450#issuecomment-910641589
It seems that tests are passing right now. @mik-laj can you also, please, confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
uranusjr closed pull request #17450:
URL: https://github.com/apache/airflow/pull/17450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kosteev commented on pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
kosteev commented on pull request #17450:
URL: https://github.com/apache/airflow/pull/17450#issuecomment-895244934
@jhtimmins James, can you please take a look if this PR makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
uranusjr closed pull request #17450:
URL: https://github.com/apache/airflow/pull/17450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kosteev commented on pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
kosteev commented on pull request #17450:
URL: https://github.com/apache/airflow/pull/17450#issuecomment-909964518
@jhtimmins @mik-laj @uranusjr Guys, is there a chance we can merge it now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kosteev commented on pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
kosteev commented on pull request #17450:
URL: https://github.com/apache/airflow/pull/17450#issuecomment-900581946
@mik-laj sure.
Are you concerned about the fact that "Op" role should have permissions to this views at all?
Anyway, let's someone else review it.
The intention of PR is to make consistent access to page with visibility of page in the menu.
So, if page is accessible by "Op" role, it should be visible in the menu. Or maybe this has to be other way around? It seems for me that "Op" role should actually have read access to these pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kosteev commented on pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
kosteev commented on pull request #17450:
URL: https://github.com/apache/airflow/pull/17450#issuecomment-909964518
@jhtimmins @mik-laj @uranusjr Guys, is there a chance we can merge it now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17450:
URL: https://github.com/apache/airflow/pull/17450#issuecomment-900420722
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kosteev closed pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
kosteev closed pull request #17450:
URL: https://github.com/apache/airflow/pull/17450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #17450:
URL: https://github.com/apache/airflow/pull/17450#issuecomment-903358131
@kosteev Can you do a rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #17450:
URL: https://github.com/apache/airflow/pull/17450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kosteev commented on pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
kosteev commented on pull request #17450:
URL: https://github.com/apache/airflow/pull/17450#issuecomment-907394527
@uranusjr Thx. Fixed test and rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17450:
URL: https://github.com/apache/airflow/pull/17450#issuecomment-904389581
```
FAILED tests/www/test_security.py::TestSecurity::test_get_user_roles_for_anonymous_user
```
This is failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #17450:
URL: https://github.com/apache/airflow/pull/17450#issuecomment-909967022
Ci was still red, so I restarted build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kosteev commented on pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
kosteev commented on pull request #17450:
URL: https://github.com/apache/airflow/pull/17450#issuecomment-903834351
@mik-laj Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #17450:
URL: https://github.com/apache/airflow/pull/17450#issuecomment-909967022
Ci was still red, so I restarted build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17450:
URL: https://github.com/apache/airflow/pull/17450#issuecomment-900420722
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kosteev commented on pull request #17450: Add missing menu access for dag dependencies and configurations pages
Posted by GitBox <gi...@apache.org>.
kosteev commented on pull request #17450:
URL: https://github.com/apache/airflow/pull/17450#issuecomment-900581946
@mik-laj sure.
Are you concerned about the fact that "Op" role should have permissions to this views at all?
Anyway, let's someone else review it.
The intention of PR is to make consistent access to page with visibility of page in the menu.
So, if page is accessible by "Op" role, it should be visible in the menu. Or maybe this has to be other way around? It seems for me that "Op" role should actually have read access to these pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org