You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/06/28 18:15:01 UTC

[GitHub] [bookkeeper] Ghatage commented on pull request #2740: [WIP] Fix Bouncy Castle fips incompatible issue

Ghatage commented on pull request #2740:
URL: https://github.com/apache/bookkeeper/pull/2740#issuecomment-869908873


   Thanks for the context @jiazhai. That helps a lot. And also thanks for doing this!. 
   Wouldn't an easy fix be to allow imports of BK's bouncy castle which were disallowed in @eolivelli's [changes here](https://github.com/eolivelli/pulsar/commit/2de612791f0334fe469e8e0a58e291358af77cdb)?
   I guess I may be over looking the reasons why they were made in the first place.
   Your changes look good otherwise 👍 
   Will you be using maven or gradle for your builds?
   
   Side note:
   @pkumar-singh Could you please help us understand how `build.gradle` is pulling in the dependencies here?
   [In these lines](https://github.com/apache/bookkeeper/blob/a445728a2ab1f6b6805c6904126fb039d71d8faf/dependencies.gradle#L27) I see bouncycastle 1.56 and bc-fips 1.0.2, both deps being pulled in. AFAIK, it's recommended to have only one or to avoid classpath conflicts and runtime errors based on which one gets loaded.
   I don't see the same in the base level maven `pom.xml`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org