You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StefanRRichter <gi...@git.apache.org> on 2018/05/29 14:24:49 UTC

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5582#discussion_r191444464
  
    --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeySerializationUtils.java ---
    @@ -138,4 +138,12 @@ private static void writeVariableIntBytes(
     			value >>>= 8;
     		} while (value != 0);
     	}
    +
    +	public static byte[] serializeKeyGroup(int keyGroup, int keyGroupPrefixBytes) {
    +		byte[] startKeyGroupPrefixBytes = new byte[keyGroupPrefixBytes];
    --- End diff --
    
    Maybe we can rather pass the `startKeyGroupPrefixBytes` array directly instead of creating it in every invocation from `keyGroupPrefixBytes`. Like that, the caller can reuse the same array.


---