[GitHub] [pinot] walterddr commented on a diff in pull request #10423: [multistage] proper support for column-level null handling

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10423:
URL: https://github.com/apache/pinot/pull/10423#discussion_r1183232264


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/catalog/PinotCatalog.java:
##########
@@ -127,4 +128,20 @@ public boolean isMutable() {
   public Schema snapshot(SchemaVersion version) {
     return this;
   }
+
+  private static boolean isNullEnabled(TableCache tableCache, String rawTableName) {
+    TableConfig tableConfig = tableCache.getTableConfig(
+        TableNameBuilder.forType(org.apache.pinot.spi.config.table.TableType.REALTIME)
+            .tableNameWithType(rawTableName));
+    if (tableConfig == null) {
+      tableConfig = tableCache.getTableConfig(
+          TableNameBuilder.forType(org.apache.pinot.spi.config.table.TableType.OFFLINE)
+              .tableNameWithType(rawTableName));
+    }
+    if (tableConfig != null && tableConfig.getIndexingConfig() != null) {
+      return tableConfig.getIndexingConfig().isNullHandlingEnabled();

Review Comment:
   wouldn't this address your concern @ankitsultana 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org